From: Rusty Russell <rusty@rustcorp.com.au>
To: Russell King <rmk@arm.linux.org.uk>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: IPv4 NAT doesn't compile in 2.4.4
Date: Wed, 02 May 2001 14:57:55 +1000 [thread overview]
Message-ID: <m14uoi4-001QJwC@mozart> (raw)
In-Reply-To: Your message of "Sat, 28 Apr 2001 17:25:54 +0100." <20010428172554.H21792@flint.arm.linux.org.uk>
In message <20010428172554.H21792@flint.arm.linux.org.uk> you write:
> net/network.o: In function `init_or_cleanup':
> net/network.o(.text+0x4a530): relocation truncated to fit: R_ARM_PC24 ip_nat_
cleanup
My bad: Russell, you're absolutely right.
Obvious fix below.
Thanks!
Rusty.
diff -urN -I \$.*\$ -X /tmp/kerndiff.guovnD --minimal linux-2.4.4-official/net/ipv4/netfilter/ip_nat_core.c tmp/net/ipv4/netfilter/ip_nat_core.c
--- linux-2.4.4-official/net/ipv4/netfilter/ip_nat_core.c Tue May 1 12:27:32 2001
+++ tmp/net/ipv4/netfilter/ip_nat_core.c Wed May 2 14:55:01 2001
@@ -890,13 +890,14 @@
}
/* Clear NAT section of all conntracks, in case we're loaded again. */
-static int __exit clean_nat(const struct ip_conntrack *i, void *data)
+static int clean_nat(const struct ip_conntrack *i, void *data)
{
memset((void *)&i->nat, 0, sizeof(i->nat));
return 0;
}
-void __exit ip_nat_cleanup(void)
+/* Not __exit: called from ip_nat_standalone.c:init_or_cleanup() --RR */
+void ip_nat_cleanup(void)
{
ip_ct_selective_cleanup(&clean_nat, NULL);
ip_conntrack_destroyed = NULL;
--
Premature optmztion is rt of all evl. --DK
prev parent reply other threads:[~2001-05-02 6:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-28 16:25 IPv4 NAT doesn't compile in 2.4.4 Russell King
2001-04-28 21:07 ` David S. Miller
2001-04-28 21:21 ` Russell King
2001-04-28 21:24 ` David S. Miller
2001-05-02 4:57 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m14uoi4-001QJwC@mozart \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox