public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: "Michael S. Tsirkin" <mst@dev.mellanox.co.il>
Cc: Roland Dreier <rdreier@cisco.com>, Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org,
	Jack Morgenstein <jackm@mellanox.co.il>
Subject: Re: pgprot_writecombine() and PATs on x86
Date: Thu, 26 Apr 2007 00:13:44 -0600	[thread overview]
Message-ID: <m1647joe7b.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070426054333.GN5217@mellanox.co.il> (Michael S. Tsirkin's message of "Thu, 26 Apr 2007 08:43:33 +0300")

"Michael S. Tsirkin" <mst@dev.mellanox.co.il> writes:

>> So in general the pci prefetchable attribute means write-combining as
>> well as prefetching is safe.  A sane BIOS will allocate prefetchable
>> BARS contiguously in the address space.  So on a good day you
>> can just use one MTRR to map all of the prefetchable BARs as write-combining.
>
> Good point, and sounds easy enough.
> So why does not linux do it automatically then where possible?

It does when we have support in the page tables.  The MTRRs appear
to complex to use automatically.  Getting the all of the memory
set to write-back using the can be a chore.  If things were truly
straight forward every BIOS would setup write-combining automatically.

> There are sure to be some broken devices, but if some device
> can't live with WC, we can always disable WC system-wide.

Yes.

Eric

  reply	other threads:[~2007-04-26  6:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-25 18:02 pgprot_writecombine() and PATs on x86 Roland Dreier
2007-04-25 18:19 ` Andi Kleen
2007-04-25 18:31   ` Eric W. Biederman
2007-04-25 18:35     ` Roland Dreier
2007-04-25 18:45       ` Eric W. Biederman
2007-04-26  5:43         ` Michael S. Tsirkin
2007-04-26  6:13           ` Eric W. Biederman [this message]
2007-04-25 18:33   ` Roland Dreier
2007-04-25 18:41   ` Dave Jones
2007-04-25 19:10     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1647joe7b.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=ak@suse.de \
    --cc=jackm@mellanox.co.il \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@dev.mellanox.co.il \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox