From: ebiederm@xmission.com (Eric W. Biederman)
To: vgoyal@in.ibm.com
Cc: Magnus Damm <magnus@valinux.co.jp>,
fastboot@lists.osdl.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@osdl.org>
Subject: Re: [Fastboot] Re: [PATCH 02/03] kexec: Avoid overwriting the current pgd (V2, i386)
Date: Wed, 24 May 2006 20:18:57 -0600 [thread overview]
Message-ID: <m164juu9ri.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060524225845.GB23291@in.ibm.com> (Vivek Goyal's message of "Wed, 24 May 2006 18:58:45 -0400")
Vivek Goyal <vgoyal@in.ibm.com> writes:
> On Wed, May 24, 2006 at 01:40:41PM +0900, Magnus Damm wrote:
>>
>> @@ -170,45 +151,16 @@ void machine_kexec_cleanup(struct kimage
>> NORET_TYPE void machine_kexec(struct kimage *image)
>> {
>> unsigned long page_list;
>> - unsigned long reboot_code_buffer;
>> -
>> + unsigned long control_code;
>> + unsigned long page_table_a;
>> relocate_new_kernel_t rnk;
>>
>> - /* Interrupts aren't acceptable while we reboot */
>> - local_irq_disable();
>
> Why are you getting rid of this call? Looks sane to disable interrupts
> early.
Agreed, this and changing the segment and idt handling is gratuitous.
If you are going to make multiple unrelated changes place do them
as separate patches.
Eric
next prev parent reply other threads:[~2006-05-25 2:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-24 4:40 [PATCH 00/03] kexec: Avoid overwriting the current pgd (V2) Magnus Damm
2006-05-24 4:40 ` [PATCH 01/03] kexec: Avoid overwriting the current pgd (V2, stubs) Magnus Damm
2006-05-25 2:41 ` [Fastboot] " Eric W. Biederman
2006-05-25 3:45 ` Magnus Damm
2006-05-25 4:37 ` Eric W. Biederman
2006-05-25 7:11 ` Magnus Damm
2006-05-25 16:36 ` Eric W. Biederman
2006-05-26 2:23 ` Magnus Damm
2006-05-24 4:40 ` [PATCH 02/03] kexec: Avoid overwriting the current pgd (V2, i386) Magnus Damm
2006-05-24 22:58 ` Vivek Goyal
2006-05-25 2:14 ` Magnus Damm
2006-05-25 2:18 ` Eric W. Biederman [this message]
2006-05-25 2:38 ` [Fastboot] " Eric W. Biederman
2006-05-24 4:40 ` [PATCH 03/03] kexec: Avoid overwriting the current pgd (V2, x86_64) Magnus Damm
2006-05-25 2:50 ` [Fastboot] " Eric W. Biederman
2006-05-25 8:26 ` Magnus Damm
2006-05-25 15:21 ` Vivek Goyal
2006-05-26 10:42 ` Magnus Damm
2006-05-26 15:08 ` Vivek Goyal
2006-05-26 15:52 ` Magnus Damm
2006-05-25 16:01 ` Eric W. Biederman
2006-05-26 3:17 ` Magnus Damm
2006-05-26 16:32 ` Eric W. Biederman
2006-05-29 8:40 ` Magnus Damm
2006-05-31 17:19 ` Vivek Goyal
2006-05-26 7:40 ` Gerd Hoffmann
2006-05-26 9:02 ` Magnus Damm
2006-05-26 9:18 ` Eric W. Biederman
2006-05-26 9:29 ` Magnus Damm
2006-05-24 22:56 ` [PATCH 00/03] kexec: Avoid overwriting the current pgd (V2) Vivek Goyal
2006-05-25 2:09 ` Magnus Damm
2006-05-25 2:56 ` Eric W. Biederman
2006-05-25 3:30 ` Magnus Damm
2006-05-25 4:51 ` Eric W. Biederman
2006-05-25 7:29 ` [Fastboot] " Magnus Damm
2006-05-25 16:40 ` Eric W. Biederman
2006-05-26 1:57 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m164juu9ri.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=fastboot@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus@valinux.co.jp \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox