From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751252AbZKWFMw (ORCPT ); Mon, 23 Nov 2009 00:12:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750873AbZKWFMv (ORCPT ); Mon, 23 Nov 2009 00:12:51 -0500 Received: from out02.mta.xmission.com ([166.70.13.232]:46738 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbZKWFMv (ORCPT ); Mon, 23 Nov 2009 00:12:51 -0500 To: Yinghai Lu Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "linux-kernel\@vger.kernel.org" References: <4B09E2F9.7040403@kernel.org> <4B0A0341.9090305@kernel.org> From: ebiederm@xmission.com (Eric W. Biederman) Date: Sun, 22 Nov 2009 21:12:45 -0800 In-Reply-To: <4B0A0341.9090305@kernel.org> (Yinghai Lu's message of "Sun\, 22 Nov 2009 19\:36\:33 -0800") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-XM-SPF: eid=;;;mid=;;;hst=in01.mta.xmission.com;;;ip=76.21.114.89;;;frm=ebiederm@xmission.com;;;spf=neutral X-SA-Exim-Connect-IP: 76.21.114.89 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH] x86: crash kernel reserve with reserve_early -v2 X-SA-Exim-Version: 4.2.1 (built Thu, 25 Oct 2007 00:26:12 +0000) X-SA-Exim-Scanned: No (on in01.mta.xmission.com); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yinghai Lu writes: > Eric W. Biederman wrote: >> Yinghai Lu writes: >> >>> use find_e820_area/reserve_early instead. >>> >>> -v2: address Eric's request, to restore original semantics. >>> will fail, if the provided address can not be used. >> >> This patch seems reasonable. >> >> YH what is the benefit of using reserve_early, and moving >> reserve_crashkernel earlier? > > old way mixing find_e820_area and reserve_bootmem like bandit... Sounds like bitrot of the best practices. > also there are some effects to remove bootmem, so we try to reduce bootmem reference. Makes sense. Extent based allocators early allocators are much more efficient. Eric