From: ebiederm@xmission.com (Eric W. Biederman)
To: David Miller <davem@davemloft.net>
Cc: cfriesen@nortel.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] ipconfig: handle case of delayed DHCP server
Date: Sun, 10 May 2009 00:53:03 -0700 [thread overview]
Message-ID: <m17i0pwg0w.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20090508.143947.207466029.davem@davemloft.net> (David Miller's message of "Fri\, 08 May 2009 14\:39\:47 -0700 \(PDT\)")
David Miller <davem@davemloft.net> writes:
> From: "Chris Friesen" <cfriesen@nortel.com>
> Date: Fri, 08 May 2009 14:56:11 -0600
>
>>
>> + /* Is it a reply for the device we are configuring? */
>> + if (b->xid != ic_dev_xid) {
>> + if (net_ratelimit())
>> + printk(KERN_ERR "DHCP/BOOTP: Ignoring delayed packet \n");
>> + goto drop_unlock;
>
> Please don't use such odd indentation for this printk
> statement.
Weird it looked ok in my mailer 3 tabs in, and out to coloumn 82. Dave someting
word wrap it for you?
Eric
next prev parent reply other threads:[~2009-05-10 7:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 20:56 [PATCH] ipconfig: handle case of delayed DHCP server Chris Friesen
2009-05-08 21:39 ` David Miller
2009-05-10 7:53 ` Eric W. Biederman [this message]
2009-05-10 8:08 ` David Miller
2009-05-11 17:44 ` Chris Friesen
2009-05-18 3:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m17i0pwg0w.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=cfriesen@nortel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox