2.6.27-rc6-mmotm0913 build error - fs-sysfs-dirc-remove-unused-__sysfs_get_dentry.patch

2.6.27-rc6-mmotm0913 build error - fs-sysfs-dirc-remove-unused-__sysfs_get_dentry.patch

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

Trying to build 2.6.27-rc6-mmotm0913 dies a horrid death:

  CC      fs/sysfs/dir.o
fs/sysfs/dir.c: In function ‘sysfs_mv_dir’:
fs/sysfs/dir.c:993: error: implicit declaration of function ‘__sysfs_get_dentry’
fs/sysfs/dir.c:993: warning: assignment makes pointer from integer without a cast
make[2]: *** [fs/sysfs/dir.o] Error 1
make[1]: *** [fs/sysfs] Error 2
make: *** [fs] Error 2


Diagnosis: Andrew added fs-sysfs-dirc-remove-unused-__sysfs_get_dentry.patch,
but somebody (Eric? was touching a lot of sysfs) in linux-next.patch added a
new user in sysfs_mv_dir.

Looks like people need to get on the same page about that patch?



[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 2.6.27-rc6-mmotm0913 build error - fs-sysfs-dirc-remove-unused-__sysfs_get_dentry.patch

[Eric W. Biederman]

Valdis.Kletnieks@vt.edu writes:

> Trying to build 2.6.27-rc6-mmotm0913 dies a horrid death:
>
>   CC      fs/sysfs/dir.o
> fs/sysfs/dir.c: In function sysfs_mv_dir:
> fs/sysfs/dir.c:993: error: implicit declaration of function
> __sysfs_get_dentry
> fs/sysfs/dir.c:993: warning: assignment makes pointer from integer without a
> cast
> make[2]: *** [fs/sysfs/dir.o] Error 1
> make[1]: *** [fs/sysfs] Error 2
> make: *** [fs] Error 2
>
>
> Diagnosis: Andrew added fs-sysfs-dirc-remove-unused-__sysfs_get_dentry.patch,
> but somebody (Eric? was touching a lot of sysfs) in linux-next.patch added a
> new user in sysfs_mv_dir.

Thanks that is a very helpful diagnosis.

> Looks like people need to get on the same page about that patch?

Greg stopped halfway through merging my patchset earlier, so I'm
guessing that is why __sysfs_get_dentry looked unused.  

As seen above I really did use that function ;) So a patch
to remove it is the wrong thing.

Eric