From: ebiederm@xmission.com (Eric W. Biederman)
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Thomas Gleixner" <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"Dhaval Giani" <dhaval@linux.vnet.ibm.com>,
"Mike Travis" <travis@sgi.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/33] dyn_array and nr_irqs support v4
Date: Wed, 06 Aug 2008 13:32:49 -0700 [thread overview]
Message-ID: <m17iatkhou.fsf@frodo.ebiederm.org> (raw)
In-Reply-To: <86802c440808061150h3ad31052j8aa5ccc4a54edb2d@mail.gmail.com> (Yinghai Lu's message of "Wed, 6 Aug 2008 11:50:53 -0700")
"Yinghai Lu" <yhlu.kernel@gmail.com> writes:
>>>
>>> - Introduce get_irq_desc and the functions or function modifications
>>> that pass a struct irq_desc * into the genirq code.
>>>
>>> Although I absolutely hate the name get_irq_desc as it implies we are
>>> reference counting something and need a corresponding put_irq_desc.
>>> Since the lifetime rules don't require that. Please just call the
>>> function irq_desc().
>>
>> will check that.
>>
> how about get_irq_desc_without_new()?
>
> irq_desc_without_new()
Possibly irq_desc_with_new() or even create_irq_desc in the one or two code paths that care.
Everywhere else can reasonably assume that the irq_desc entries have either been setup, or that
the irq number is invalid.
Eric
next prev parent reply other threads:[~2008-08-06 20:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <No>
2008-08-06 8:38 ` [PATCH 00/33] dyn_array and nr_irqs support v4 Yinghai Lu
2008-08-06 8:38 ` [PATCH 01/33] x86: add after_bootmem for 32bit Yinghai Lu
2008-08-06 8:38 ` [PATCH 02/33] x86: remove irq_vectors_limits Yinghai Lu
2008-08-06 17:37 ` [PATCH 00/33] dyn_array and nr_irqs support v4 Eric W. Biederman
2008-08-06 18:29 ` Yinghai Lu
2008-08-06 18:50 ` Yinghai Lu
2008-08-06 20:32 ` Eric W. Biederman [this message]
2008-08-06 20:52 ` Yinghai Lu
2008-08-06 20:35 ` Eric W. Biederman
2008-08-06 20:57 ` Yinghai Lu
2008-08-06 23:26 ` Alan Cox
2008-08-07 1:02 ` Eric W. Biederman
2008-08-07 10:12 ` Alan Cox
2008-08-07 10:51 ` Yinghai Lu
2008-08-07 10:57 ` Alan Cox
2008-08-07 18:12 ` H. Peter Anvin
2008-08-06 8:42 Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m17iatkhou.fsf@frodo.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox