public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] fix handling of st_nlink on procfs root
Date: Wed, 08 Feb 2006 18:04:36 -0700	[thread overview]
Message-ID: <m17j855om3.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <E1F6vyO-00009r-3a@ZenIV.linux.org.uk> (Al Viro's message of "Wed, 08 Feb 2006 20:31:32 +0000")

Al Viro <viro@ftp.linux.org.uk> writes:

> Date: 1139427460 -0500
>
> 1) it should use nr_processes(), not nr_threads; otherwise we are getting
> very confused find(1) and friends, among other things.
> 2) better do that at stat() time than at every damn lookup in procfs root.
>
> Patch had been sitting in FC4 kernels for many months now...

Ack.

There are some other similar problems still in /proc.

In my pid namespace work I have some managed to clean most of
this up, and finally split proc into two filesystems.

The only was I was able to get the union to work was
to let lookup return files in an internal mount.

The only problem was that /proc/irq/..  != /proc/

I will finish all of this up shortly but do you know a good
way to do a union mount when we mount proc?

Eric

  reply	other threads:[~2006-02-09  1:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-08 20:31 [PATCH 8/8] fix handling of st_nlink on procfs root Al Viro
2006-02-09  1:04 ` Eric W. Biederman [this message]
2006-02-09  2:17   ` Al Viro
2006-02-09  3:14     ` Eric W. Biederman
2006-02-15  9:20 ` Eric W. Biederman
2006-02-15 10:39   ` Al Viro
2006-02-15 17:35     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m17j855om3.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox