From: rct@gherkin.frus.com (Bob_Tracy)
To: dag@brattli.net
Cc: linux-kernel@vger.kernel.org
Subject: 2.5.34: IR __FUNCTION__ breakage
Date: Thu, 12 Sep 2002 14:54:01 -0500 (CDT) [thread overview]
Message-ID: <m17pa2L-0005khC@gherkin.frus.com> (raw)
I've been painstakingly going through all the IR code and fixing up
the __FUNCTION__ breakage. One of the not obvious patches is for
linux/net/irda/irnet/irnet.h, where string concatenation was fully
taken advantage of :-).
The problem lies in statements such as
#define DERROR(dbg, args...) \
{if(DEBUG_##dbg) \
printk(KERN_INFO "irnet: " __FUNCTION__ "(): " args);}
where you really want to avoid having any format strings because
"args" could legally have one (and probably will). Under the
circumstances, one option might be something like
define DERROR(dbg, args...) \
{if(DEBUG_##dbg){\
printk(KERN_INFO "irnet: %s(): ", __FUNCTION__);\
printk(KERN_INFO args);}}
which strikes me as not quite what the author intended, although it
should work. Better ideas are welcome, and if a consensus is reached,
I'll be happy to submit the full IR __FUNCTION__ patch set against
2.5.34 for inclusion in a later kernel version.
--
-----------------------------------------------------------------------
Bob Tracy WTO + WIPO = DMCA? http://www.anti-dmca.org
rct@frus.com
-----------------------------------------------------------------------
next reply other threads:[~2002-09-12 19:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-12 19:54 Bob_Tracy [this message]
2002-09-12 20:16 ` 2.5.34: IR __FUNCTION__ breakage Thunder from the hill
2002-09-12 21:09 ` Bob_Tracy
2002-09-13 16:01 ` Andreas Steinmetz
2002-09-13 16:14 ` Thunder from the hill
2002-09-13 17:46 ` Ahmed Masud
2002-09-13 18:01 ` Andreas Steinmetz
2002-09-13 20:11 ` Thunder from the hill
2002-09-13 20:12 ` Neil Booth
2002-09-13 20:30 ` Andreas Steinmetz
2002-09-13 20:53 ` Thunder from the hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m17pa2L-0005khC@gherkin.frus.com \
--to=rct@gherkin.frus.com \
--cc=dag@brattli.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox