Re: [PATCH 00/69] faster tree-based sysctl implementation

Lucian Adrian Grijincu
2011-05-02T21:43:39Z

On Mon, May 2, 2011 at 9:02 PM, Eric W. Biederman <ebiederm@xmission.com> wrote:
> Do you also have a lot of network namespaces in the workloads you care
> about?

No, the usecase deals with high number of netdevices.

The cookie can be used in lots of places that kmemdup ctl_table arrays
and then set ->data to be the address of a member of a structure.
- netdevice config sysctls
- netns specific sysctls (e.g. net/somaxconn
- parport device specific sysctls
- cpu sched domain config sysctls
- et. al.

I sent another series sometime in February that added the cookie to
ipv4/6 conf sysctls.
I don't know why I did not include that in the patch series from April.

> The cookie changes seem particularly intrusive, and if I read your
> patches properly the cookies are only useful for table sharing when
> implementing network namespaces.  At first glance those changes seem
> pretty horrible.

I know it's ugly. I was thinking about this today. I think I have a
cleaner solution, that I'll post after this patch series.

--
.
..: Lucian