From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752696AbYKZG0U (ORCPT ); Wed, 26 Nov 2008 01:26:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750971AbYKZG0J (ORCPT ); Wed, 26 Nov 2008 01:26:09 -0500 Received: from out02.mta.xmission.com ([166.70.13.232]:50826 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbYKZG0I (ORCPT ); Wed, 26 Nov 2008 01:26:08 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Steven Rostedt Cc: Dave Hansen , Andrew Morton , containers@lists.osdl.org, fweisbec@gmail.com, Ingo Molnar , LKML , srostedt@redhat.com, Sukadev Bhattiprolu , "Serge E. Hallyn" References: <20081125223421.795046329@goodmis.org> <20081125223456.976670734@goodmis.org> <20081125144221.66eb99ad.akpm@linux-foundation.org> <20081125153104.ecdceed4.akpm@linux-foundation.org> <1227660839.12109.52.camel@nimitz> Date: Tue, 25 Nov 2008 22:23:16 -0800 In-Reply-To: (Steven Rostedt's message of "Wed, 26 Nov 2008 00:01:08 -0500 (EST)") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-XM-SPF: eid=;;;mid=;;;hst=mx04.mta.xmission.com;;;ip=24.130.11.59;;;frm=ebiederm@xmission.com;;;spf=neutral X-SA-Exim-Connect-IP: 24.130.11.59 X-SA-Exim-Rcpt-To: too long (recipient list exceeded maximum allowed size of 128 bytes) X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-DCC: XMission; sa01 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Steven Rostedt X-Spam-Relay-Country: X-Spam-Report: * -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% * [score: 0.0000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa01 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 XM_SPF_Neutral SPF-Neutral Subject: Re: [PATCH 1/3] ftrace: add function tracing to single thread X-SA-Exim-Version: 4.2.1 (built Thu, 07 Dec 2006 04:40:56 +0000) X-SA-Exim-Scanned: Yes (on mx04.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Steven Rostedt writes: > On Tue, 25 Nov 2008, Eric W. Biederman wrote: > >> >> > > I'm speechless too. I'm a bit tired so probably am pushing to hard. At the same time I don't see a single reason not to use struct pid for what it was designed for. Identifying tasks. pid_t's really only belong at the border. I can see in the tracer when grabbing numbers you might not be able to follow pointers. For that I see justification for using task->pid. For the comparison I just don't see it. Eric