From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752656Ab1LLH2y (ORCPT ); Mon, 12 Dec 2011 02:28:54 -0500 Received: from out01.mta.xmission.com ([166.70.13.231]:56822 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492Ab1LLH2w (ORCPT ); Mon, 12 Dec 2011 02:28:52 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Cyrill Gorcunov Cc: KAMEZAWA Hiroyuki , Andrew Morton , Tejun Heo , Andrew Vagin , Serge Hallyn , Vasiliy Kulikov , Kees Cook , Alexey Dobriyan , LKML References: <20111205182010.GV14515@moon> <20111206140833.3b43fbeb.akpm@linux-foundation.org> <20111206221515.GP29781@moon> <20111206225315.GA20459@moon> <20111207090259.e2296dd3.kamezawa.hiroyu@jp.fujitsu.com> <20111207063308.GC20459@moon> <20111207070718.GA21678@moon> Date: Sun, 11 Dec 2011 23:30:21 -0800 In-Reply-To: <20111207070718.GA21678@moon> (Cyrill Gorcunov's message of "Wed, 7 Dec 2011 11:07:18 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-XM-SPF: eid=;;;mid=;;;hst=in01.mta.xmission.com;;;ip=98.207.153.68;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18b5AD6Xw2e3QYohzFll5Lx1PNG5JY5DBk= X-SA-Exim-Connect-IP: 98.207.153.68 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * 7.0 XM_URI_RBL URI blacklisted in uri.bl.xmission.com * [URIs: openvz.org] * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -3.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] * 0.5 XM_Body_Dirty_Words Contains a dirty word * 0.0 T_TooManySym_01 4+ unique symbols in subject * 0.0 T_TooManySym_02 5+ unique symbols in subject * 0.0 T_XMDrugObfuBody_04 obfuscated drug references * 0.4 UNTRUSTED_Relay Comes from a non-trusted relay X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ****;Cyrill Gorcunov X-Spam-Relay-Country: Subject: Re: [PATCH] fs, proc: Add start_data, end_data, start_brk members to /proc/$pid/stat v2 X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Fri, 06 Aug 2010 16:31:04 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cyrill Gorcunov writes: > On Wed, Dec 07, 2011 at 10:33:08AM +0400, Cyrill Gorcunov wrote: >> >> No problem, I'll update (These segments are filled by binfmt handlers). >> > > This one should fit. How extensively have you tested this. I remember a few other occasions where adding elements to a line in a proc file have resulted in breaking readers. I expect it is much safer to add this to /proc//status rather than /proc//stat. Eric > > Cyrill > --- > From: Cyrill Gorcunov > Subject: [PATCH] fs, proc: Add start_data, end_data, start_brk members to /proc/$pid/stat v4 > > These members are involved into calculation of program > data segment (which might be seen in /proc//statm) > and into brk() call, so in a sake of restore we need > these entries to be set exactly to the same value the > process had at dumpimg time. > > While setting these entries back to a running task > is supposed to be done via prctl interface (which is > not addressed in this patch) the export of these values > are done via /proc/$pid/stat, which already have start_code, > end_code and start_stack entries. > > v2: > - Kees and Alexey pointed out that "1" hack is unnecessary, > so make it to have plain (mm && permitted) ? mm->member : 0 > form. > > v3: > - Andrew pointed that documentation update is missed. > Chagelog is updated as well. > > v4: > - Update proc.txt to address concerns from Kees and Kame. > > Signed-off-by: Cyrill Gorcunov > Acked-by: Serge Hallyn > Reviewed-by: Kees Cook > Reviewed-by: KAMEZAWA Hiroyuki > CC: Alexey Dobriyan > --- > Documentation/filesystems/proc.txt | 3 +++ > fs/proc/array.c | 7 +++++-- > 2 files changed, 8 insertions(+), 2 deletions(-) > > Index: linux-2.6.git/Documentation/filesystems/proc.txt > =================================================================== > --- linux-2.6.git.orig/Documentation/filesystems/proc.txt > +++ linux-2.6.git/Documentation/filesystems/proc.txt > @@ -305,6 +305,9 @@ Table 1-4: Contents of the stat files (a > blkio_ticks time spent waiting for block IO > gtime guest time of the task in jiffies > cgtime guest time of the task children in jiffies > + start_data address above which program data+bss is placed > + end_data address below which program data+bss is placed > + start_brk address above which program heap can be expaned with brk() call > .............................................................................. > > The /proc/PID/maps file containing the currently mapped memory regions and > Index: linux-2.6.git/fs/proc/array.c > =================================================================== > --- linux-2.6.git.orig/fs/proc/array.c > +++ linux-2.6.git/fs/proc/array.c > @@ -464,7 +464,7 @@ static int do_task_stat(struct seq_file > > seq_printf(m, "%d (%s) %c %d %d %d %d %d %u %lu \ > %lu %lu %lu %lu %lu %ld %ld %ld %ld %d 0 %llu %lu %ld %lu %lu %lu %lu %lu \ > -%lu %lu %lu %lu %lu %lu %lu %lu %d %d %u %u %llu %lu %ld\n", > +%lu %lu %lu %lu %lu %lu %lu %lu %d %d %u %u %llu %lu %ld %lu %lu %lu\n", > pid_nr_ns(pid, ns), > tcomm, > state, > @@ -511,7 +511,10 @@ static int do_task_stat(struct seq_file > task->policy, > (unsigned long long)delayacct_blkio_ticks(task), > cputime_to_clock_t(gtime), > - cputime_to_clock_t(cgtime)); > + cputime_to_clock_t(cgtime), > + (mm && permitted) ? mm->start_data : 0, > + (mm && permitted) ? mm->end_data : 0, > + (mm && permitted) ? mm->start_brk : 0); > if (mm) > mmput(mm); > return 0; > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/