Re: 2.6.22-rc6-mm1: Xen: WARNING: Absolute relocations present

[ebiederm@xmission.com (Eric W. Biederman)]

Jeremy Fitzhardinge <jeremy@goop.org> writes:

> Eric W. Biederman wrote:
>> Jeremy Fitzhardinge <jeremy@goop.org> writes:
>>
>>
>>> Adrian Bunk wrote:
>>>
>>>> <--  snip  -->
>>>>
>>>> ...
>>>>   RELOCS  arch/i386/boot/compressed/vmlinux.relocs
>>>> WARNING: Absolute relocations present
>>>> Offset     Info     Type     Sym.Value Sym.Name
>>>> c0101f80 020c6501   R_386_32 00000000  xen_irq_disable_direct_reloc
>>>> c0101f9a 0221ea01   R_386_32 00000000  xen_save_fl_direct_reloc
>>>> ...
>>>>
>>>> <--  snip  -->
>>>>
>>>>
>>> Hm.  Those are false alarms.  I guess I could do something to hide them, but
>>> there's nothing inherently wrong with correctly used abs symbols.  Is there
>>> someway to whitelist them?
>>>
>>
>> Yes.  Just add them to arch/i386/boot/compressed/relocs.c safe_abs_syms.
>>
>
> OK, how's this?
>
> Subject: xen: suppress abs symbol warnings for unused reloc pointers
>
> The Xen code generates some abs symbols which are OK from a relocation
> perspective.

Actually I have to ask.  How in the world are these absolute symbols
ok from a relocation perspective.

If the kernel is not running at 0xc0100000 the offset value looks like
it will be completely bogus.

Maybe those are ok, but if you could please explain why those are
false positives I would appreciate it. (Especially in your patch
description).

If these are indeed false positives the patch looks ok.

Eric