From: ebiederm@xmission.com (Eric W. Biederman)
To: Andi Kleen <andi@firstfloor.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [1/2] SYSCTL: Make bin_table not const
Date: Sun, 20 Dec 2009 12:06:02 -0800 [thread overview]
Message-ID: <m1d429o1g5.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20091219211831.GA19716@basil.fritz.box> (Andi Kleen's message of "Sat\, 19 Dec 2009 22\:18\:31 +0100")
Andi Kleen <andi@firstfloor.org> writes:
> On Sat, Dec 19, 2009 at 09:40:56AM -0800, Linus Torvalds wrote:
>>
>>
>> On Sat, 19 Dec 2009, Andi Kleen wrote:
>> >
>> > Turn all the bin_tables from const to non-const. This is needed for the next
>> > patch. Unfortunately there were a lot of them, so the patch is rather
>> > large, but it is completely mechanic.
>>
>> Ouch. I hate this.
>>
>> I'd much rather have a constant sysctl bin_table.
>
> Understood. I'll poke at that and try to come up with a tested patch
> tomorrow or so.
Is printk_ratelimit truly ineffective at what it does?
Arguably we don't need to warn anywhere near that often, so even
if printk_ratelimit works we are good.
If printk_ratelimit let's too much through we really should also write
a patch to let fewer messages through that way.
Eric
next prev parent reply other threads:[~2009-12-20 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 14:58 [PATCH] [0/2] SYSCTL: Warn once for all legacy syctls Andi Kleen
2009-12-19 14:58 ` [PATCH] [1/2] SYSCTL: Make bin_table not const Andi Kleen
2009-12-19 17:40 ` Linus Torvalds
2009-12-19 21:18 ` Andi Kleen
2009-12-20 20:06 ` Eric W. Biederman [this message]
2009-12-20 21:06 ` Andi Kleen
2009-12-21 1:23 ` [PATCH] SYSCTL: Print binary sysctl warnings (nearly) only once Andi Kleen
2009-12-19 14:58 ` [PATCH] [2/2] SYSCTL: Warn once for every binary sysctl Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1d429o1g5.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox