public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, tony.luck@intel.com,
	linux-ia64@vger.kernel.org, Neil Horman <nhorman@redhat.com>,
	akpm@linux-foundation.org, Ingo Molnar <mingo@elte.hu>,
	Anton Vorontsov <avorontsov@ru.mvista.com>
Subject: Re: [Patch 0/7] Implement crashkernel=auto
Date: Wed, 05 Aug 2009 06:33:57 -0700	[thread overview]
Message-ID: <m1eirqtmey.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20090805112123.6552.73574.sendpatchset@localhost.localdomain> (Amerigo Wang's message of "Wed\, 5 Aug 2009 07\:19\:02 -0400")

Amerigo Wang <amwang@redhat.com> writes:

> This series of patch implements automatically reserved memory for crashkernel,
> by introducing a new boot option "crashkernel=auto". This idea is from Neil.
>
> In case of breaking user-space applications, it modifies this boot option after
> it decides how much memory should be reserved.
>
> On different arch, the threshold and reserved memory size is different. Please
> refer patch 7/7 which contains an update for the documentation.
>
> Note: This patchset was only tested on x86_64 with differernt memory sizes.

This seems like a silly hard code. Especially for a feature distros don't
care enough about to implement a working initrd for.

Has anyone bothered to justify those large amounts of memory?
Where does the 128M go?

Please pardon me for being a cynic but I don't see the command line option
being the bottleneck for real users to make this work.

Eric

  parent reply	other threads:[~2009-08-05 13:34 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05 11:19 [Patch 0/7] Implement crashkernel=auto Amerigo Wang
2009-08-05 11:19 ` [Patch 1/7] x86: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-05 13:41   ` Neil Horman
2009-08-05 14:45   ` Andi Kleen
2009-08-05 20:07     ` Eric W. Biederman
2009-08-06  1:55     ` Amerigo Wang
2009-08-06  7:15       ` Andi Kleen
2009-08-06  7:44         ` Amerigo Wang
2009-08-06  7:56         ` Amerigo Wang
2009-08-05 11:19 ` [Patch 2/7] x86: implement crashkernel=auto Amerigo Wang
2009-08-05 13:43   ` Neil Horman
2009-08-06  1:45     ` Amerigo Wang
2009-08-05 22:51   ` Yu, Fenghua
2009-08-06  1:56     ` Amerigo Wang
2009-08-05 11:19 ` [Patch 3/7] ia64: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-05 13:49   ` Neil Horman
2009-08-05 11:19 ` [Patch 4/7] ia64: implement crashkernel=auto Amerigo Wang
2009-08-05 13:46   ` Neil Horman
2009-08-05 11:19 ` [Patch 5/7] powerpc: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-05 13:49   ` Neil Horman
2009-08-05 11:20 ` [Patch 6/7] powerpc: implement crashkernel=auto Amerigo Wang
2009-08-05 13:50   ` Neil Horman
2009-08-05 11:20 ` [Patch 7/7] doc: update the kdump document Amerigo Wang
2009-08-05 13:33 ` Eric W. Biederman [this message]
2009-08-05 14:04   ` [Patch 0/7] Implement crashkernel=auto Neil Horman
2009-08-05 22:57     ` Eric W. Biederman
2009-08-06  2:05       ` Amerigo Wang
2009-08-06  2:47         ` Eric W. Biederman
2009-08-06  3:39           ` Amerigo Wang
2009-08-06  3:51             ` Eric W. Biederman
2009-08-06  5:57               ` Amerigo Wang
2009-08-06  6:14                 ` Eric W. Biederman
2009-08-06  6:37                   ` Amerigo Wang
2009-08-06  8:35                     ` Eric W. Biederman
2009-08-06  8:47                       ` Eric W. Biederman
2009-08-06  9:04                         ` Amerigo Wang
2009-08-07 19:13                         ` Bernhard Walle
2009-08-06  9:11                       ` Amerigo Wang
2009-08-07 19:50                         ` Eric W. Biederman
2009-08-07 21:03                           ` Andi Kleen
2009-08-07 21:26                             ` Bernhard Walle
2009-08-07 22:06                             ` Eric W. Biederman
2009-08-07 21:31                           ` Bernhard Walle
2009-08-07 22:16                             ` Eric W. Biederman
2009-08-10  3:11                           ` Amerigo Wang
2009-08-06  1:39   ` Amerigo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1eirqtmey.fsf@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=akpm@linux-foundation.org \
    --cc=amwang@redhat.com \
    --cc=avorontsov@ru.mvista.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nhorman@redhat.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox