public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Zachary Amsden <zach@vmware.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Virtualization Mailing List <virtualization@lists.osdl.org>,
	Xen-devel <xen-devel@lists.xensource.com>,
	Andrew Morton <akpm@osdl.org>, Dan Hecht <dhecht@vmware.com>,
	Dan Arai <arai@vmware.com>, Anne Holler <anne@vmware.com>,
	Pratap Subrahmanyam <pratap@vmware.com>,
	Christopher Li <chrisl@vmware.com>,
	Joshua LeVasseur <jtl@ira.uka.de>, Chris Wright <chrisw@osdl.org>,
	Rik Van Riel <riel@redhat.com>, Jyothy Reddy <jreddy@vmware.com>,
	Jack Lo <jlo@vmware.com>, Kip Macy <kmacy@fsmware.com>,
	Jan Beulich <jbeulich@novell.com>,
	Ky Srinivasan <ksrinivasan@novell.com>,
	Wim Coekaerts <wim.coekaerts@oracle.com>,
	Leendert van Doorn <leendert@watson.ibm.com>,
	Zachary Amsden <zach@vmware.com>
Subject: Re: [RFC, PATCH 14/24] i386 Vmi reboot fixes
Date: Wed, 15 Mar 2006 14:11:52 -0700	[thread overview]
Message-ID: <m1ek13xvjb.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <200603131809.k2DI9slZ005727@zach-dev.vmware.com> (Zachary Amsden's message of "Mon, 13 Mar 2006 10:09:54 -0800")

Zachary Amsden <zach@vmware.com> writes:

> Fix reboot to work with the  VMI.  We must support fallback to the standard
> BIOS reboot mechanism.  Turns out that this is required by kexec, and a good
> idea for native hardware. 

Huh?  Rebooting through the BIOS and kexec are pretty much mutually exclusive.
Looking at the patch I can't see what you are talking about either.

Does kexec successfully work under VMWare?


> We simply insert the NOP VMI reboot hook before
> calling the BIOS reboot.  While here, fix SMP reboot issues as well.  The
> problem is the halt() macro in VMI has been defined to be equivalent to
> safe_halt(), which enables interrupts.  Several call sites actually want to
> disable interrupts and shutdown the processor, which is what VMI_Shutdown()
> does.

machine_halt actually is not one of those places.

machine_halt does not want to stop the processor.  It is very much
about killing the kernel and user space but having the software still
linger a little.

This needs a cleaner abstraction to make sense or go in.

Eric

      parent reply	other threads:[~2006-03-15 21:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-13 18:09 [RFC, PATCH 14/24] i386 Vmi reboot fixes Zachary Amsden
2006-03-15 21:11 ` Eric W. Biederman
2006-03-15 23:24   ` Zachary Amsden
2006-03-16  5:03     ` Eric W. Biederman
2006-03-15 21:11 ` Eric W. Biederman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1ek13xvjb.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=akpm@osdl.org \
    --cc=anne@vmware.com \
    --cc=arai@vmware.com \
    --cc=chrisl@vmware.com \
    --cc=chrisw@osdl.org \
    --cc=dhecht@vmware.com \
    --cc=jbeulich@novell.com \
    --cc=jlo@vmware.com \
    --cc=jreddy@vmware.com \
    --cc=jtl@ira.uka.de \
    --cc=kmacy@fsmware.com \
    --cc=ksrinivasan@novell.com \
    --cc=leendert@watson.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pratap@vmware.com \
    --cc=riel@redhat.com \
    --cc=torvalds@osdl.org \
    --cc=virtualization@lists.osdl.org \
    --cc=wim.coekaerts@oracle.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox