From: ebiederm@xmission.com (Eric W. Biederman)
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jiri Kosina <jkosina@suse.cz>,
Larry Finger <Larry.Finger@lwfinger.net>,
WANG Cong <xiyou.wangcong@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] base firmware: Fix BUG from sysfs attributes change in commit a2db6842873c8e5a70652f278d469128cb52db70
Date: Sun, 14 Mar 2010 12:08:55 -0700 [thread overview]
Message-ID: <m1fx42yb3s.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1003141054050.3719@i5.linux-foundation.org> (Linus Torvalds's message of "Sun\, 14 Mar 2010 11\:04\:25 -0700 \(PDT\)")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Sun, 14 Mar 2010, Wolfram Sang wrote:
>>
>> coccinelle can apply semantic patches, rough description here [1]. So I wrote
>> one which checks for every c-file in the kernel-tree:
>>
>> - Is there a structure containing (bin_)attribute?
>> - Does a function declare a pointer to such a structure?
>> - Is this pointer then used for a sysfs_create(_bin)_file?
>> - If so, has there been a call to sysfs(_bin)_attr_init before?
>>
>> If not -> report. As coccinelle works on an abstract level of the code (not on
>> source-code level), it can follow code-paths and such. Really nice tool, once
>> you gathered the information to learn it.
Any chance you can post the semantic patch? If it isn't too hard it
would be nice to have the warm fuzzy of running it myself and seeing
that there are no more of these left in the kernel.
Eric
next prev parent reply other threads:[~2010-03-14 19:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-13 19:36 [PATCH] base firmware: Fix BUG from sysfs attributes change in commit a2db6842873c8e5a70652f278d469128cb52db70 Larry Finger
2010-03-13 22:32 ` Linus Torvalds
2010-03-13 22:39 ` Jiri Kosina
2010-03-13 22:57 ` Linus Torvalds
2010-03-14 3:57 ` Eric W. Biederman
2010-03-14 5:46 ` Linus Torvalds
2010-03-14 6:59 ` Ingo Molnar
2010-03-14 17:20 ` Linus Torvalds
2010-03-14 18:11 ` Greg KH
2010-03-14 18:30 ` Eric W. Biederman
2010-03-14 18:38 ` Greg KH
2010-03-14 10:49 ` Wolfram Sang
2010-03-14 18:04 ` Linus Torvalds
2010-03-14 18:07 ` Linus Torvalds
2010-03-14 19:08 ` Eric W. Biederman [this message]
2010-03-15 0:48 ` Wolfram Sang
2010-03-15 0:20 ` Wolfram Sang
2010-03-15 0:29 ` [PATCH] init dynamic bin_attribute structures Wolfram Sang
2010-03-15 10:00 ` Jiri Kosina
2010-03-15 10:12 ` [rtc-linux] " Wolfram Sang
2010-03-15 18:47 ` Linus Torvalds
2010-03-13 22:55 ` [PATCH] base firmware: Fix BUG from sysfs attributes change in commit a2db6842873c8e5a70652f278d469128cb52db70 Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1fx42yb3s.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@suse.de \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=w.sang@pengutronix.de \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox