From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760980AbYGQSws (ORCPT ); Thu, 17 Jul 2008 14:52:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759022AbYGQSwX (ORCPT ); Thu, 17 Jul 2008 14:52:23 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:34477 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757763AbYGQSwW (ORCPT ); Thu, 17 Jul 2008 14:52:22 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: "Daniel Hokka Zakrisson" Cc: linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, oleg@tv-sign.ru, xemul@openvz.org, akpm@linux-foundation.org References: <487F5DA1.6000107@hozac.com> <49797.192.168.102.6.1216318897.squirrel@intranet> Date: Thu, 17 Jul 2008 11:51:38 -0700 In-Reply-To: <49797.192.168.102.6.1216318897.squirrel@intranet> (Daniel Hokka Zakrisson's message of "Thu, 17 Jul 2008 20:21:37 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SA-Exim-Connect-IP: 24.130.11.59 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-DCC: XMission; sa02 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;"Daniel Hokka Zakrisson" X-Spam-Relay-Country: X-Spam-Report: * -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * 0.0 BAYES_50 BODY: Bayesian spam probability is 40 to 60% * [score: 0.4345] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa02 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 XM_SPF_Neutral SPF-Neutral Subject: Re: [PATCH 2/2] signals: replace p->pid == 1 check with a check for task_child_reaper X-SA-Exim-Version: 4.2 (built Thu, 03 Mar 2005 10:44:12 +0100) X-SA-Exim-Scanned: Yes (on mgr1.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Daniel Hokka Zakrisson" writes: > Eric W. Biederman wrote: >> Daniel Hokka Zakrisson writes: >> >>> p->pid == 1 is insufficient when there are multiple pid namespaces. >>> Instead, check whether the task is in the current task's >>> child reaper's thread group. >> >> We should just drop the check for init as it is redundant. Sorry that was a half truth. Outside of the context of pid namespaces it is true. In the context of pid namespaces it is false because we haven't merged the patches to drop signals from inside the pid namespace on the way to init. So it is a check that _should_ be redundant. Eric