From: ebiederm@xmission.com (Eric W. Biederman)
To: Ingo Molnar <mingo@elte.hu>
Cc: "Pan\, Jacob jun" <jacob.jun.pan@intel.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@linux.intel.com>
Subject: Re: [PATCH 8/9] x86/apic: match destination id with destination mode
Date: Fri, 26 Jun 2009 12:54:10 -0700 [thread overview]
Message-ID: <m1hby293fh.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20090626071725.GE14078@elte.hu> (Ingo Molnar's message of "Fri\, 26 Jun 2009 09\:17\:25 +0200")
Ingo Molnar <mingo@elte.hu> writes:
> The question here is whether this should layer on top of Jeremy's
> IO-APIC driverization patches. I think it should.
The patch is a bad hack that is totally misdocumented. A bit
like the Xen apic changes in that respect.
I haven't seen Jeremy's IO-APIC driverization patches.
I am stumped why we need any driverization in this area. x86_64 and has
had for years a mechanism that is perfectly fine for abstracting this.
i386 also has had something similar and last I looked we just about
had that code merged.
Xen doesn't have ioapics so it doesn't need us faking writes to
ioapics. Xen either needs to parse the ioapic tables itself
or Xen needs a proper interface to be given the table information.
I this patch can be replaced by a 2 line change to the apic mode
logic to force us into physflat mode on moorestown.
Eric
next prev parent reply other threads:[~2009-06-26 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 0:15 [PATCH 8/9] x86/apic: match destination id with destination mode Pan, Jacob jun
2009-06-26 7:17 ` Ingo Molnar
2009-06-26 19:54 ` Eric W. Biederman [this message]
2009-06-26 20:59 ` Pan, Jacob jun
2009-06-26 21:47 ` Eric W. Biederman
2009-06-27 17:01 ` Ingo Molnar
2009-06-26 19:45 ` Eric W. Biederman
2009-06-26 21:21 ` Yinghai Lu
2009-06-26 21:41 ` Pan, Jacob jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1hby293fh.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=hpa@linux.intel.com \
--cc=jacob.jun.pan@intel.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox