From: ebiederm@xmission.com (Eric W. Biederman)
To: David Rientjes <rientjes@google.com>
Cc: David Miller <davem@davemloft.net>,
eric.dumazet@gmail.com, jpiszcz@lucidpixels.com,
linux-kernel@vger.kernel.org
Subject: Re: [patch] ipv4: don't warn about skb ack allocation failures
Date: Fri, 19 Jun 2009 18:28:49 -0700 [thread overview]
Message-ID: <m1hbybwv5a.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <alpine.DEB.2.00.0906191524470.30455@chino.kir.corp.google.com> (David Rientjes's message of "Fri\, 19 Jun 2009 15\:37\:17 -0700 \(PDT\)")
David Rientjes <rientjes@google.com> writes:
> On Fri, 19 Jun 2009, Eric W. Biederman wrote:
>
>> But Mr. Reintjes if you really want the traces I can set up
>> an script to email them to you every time it happens. Say about
>> 1 a minute from my paltry little farm of machines.
>>
>
> Perhaps you missed my email where I suggested emitting the page allocation
> warnings only when CONFIG_DEBUG_VM is enabled. It's at
> http://lkml.org/lkml/2009/6/18/355.
>
> We can then keep the __GFP_NOFAIL flag to indicate that the warnings
> should never be emitted for that allocation, regardless of the .config.
>
> It's funny, though, that the problem that originally started this thread
> was quickly diagnosed because of these messages. As far as I know, my
> suggestion to increase /proc/sys/vm/dirty_background_ratio to kick pdflush
> earlier has prevented the slab allocation failures and not required
> delayed acks for nfsd.
increase?
Perhaps then the problem is simply dirty_background_ratio. Is the vm
not properly autotuning?
With a 50MB/s disk I wonder what the proper window size is. Several
gigabytes as implied by a 5% or a 10% dirty_background_ratio seems
absurd. TCP sockets seem to get along fine with even large latencies
and windows measured in megabytes not gigabytes.
This does explain a few things.
Eric
next prev parent reply other threads:[~2009-06-20 1:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.00.0906161203160.27742@p34.internal.lan>
2009-06-16 16:06 ` 2.6.29.1: nfsd: page allocation failure - nfsd or kernel problem? Justin Piszcz
2009-06-16 20:19 ` Michael Tokarev
2009-06-17 8:43 ` Michael Tokarev
2009-06-17 9:43 ` Justin Piszcz
2009-06-17 10:39 ` Michael Tokarev
2009-06-17 18:51 ` J. Bruce Fields
2009-06-17 20:24 ` Michael Tokarev
2009-06-17 20:39 ` David Rientjes
2009-06-18 8:54 ` Michael Tokarev
2009-06-18 17:07 ` David Rientjes
2009-06-18 17:56 ` Michael Tokarev
2009-06-18 18:12 ` J. Bruce Fields
2009-06-18 18:15 ` David Rientjes
2009-06-17 22:45 ` J. Bruce Fields
2009-06-18 0:14 ` Zdenek Kaspar
2009-06-17 19:44 ` [patch] ipv4: don't warn about skb ack allocation failures David Rientjes
2009-06-17 20:16 ` Eric Dumazet
2009-06-17 20:33 ` David Rientjes
2009-06-17 20:52 ` Eric Dumazet
2009-06-17 21:12 ` David Rientjes
2009-06-17 22:30 ` Eric Dumazet
2009-06-17 23:08 ` David Miller
2009-06-18 16:56 ` David Rientjes
2009-06-18 19:00 ` David Miller
2009-06-18 19:23 ` David Rientjes
2009-06-18 19:37 ` David Miller
2009-06-19 19:45 ` David Rientjes
2009-06-19 20:41 ` Eric W. Biederman
2009-06-19 22:37 ` David Rientjes
2009-06-19 23:04 ` David Miller
2009-06-20 1:28 ` Eric W. Biederman [this message]
2009-06-19 23:03 ` David Miller
2009-06-22 16:08 ` 2.6.30: nfsd: page allocation failure - nfsd or kernel problem? (again with 2.6.30) Justin Piszcz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1hbybwv5a.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jpiszcz@lucidpixels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox