From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932162AbXC1D1P (ORCPT ); Tue, 27 Mar 2007 23:27:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933575AbXC1D1P (ORCPT ); Tue, 27 Mar 2007 23:27:15 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:41995 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932162AbXC1D1O (ORCPT ); Tue, 27 Mar 2007 23:27:14 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Michael Ellerman Cc: linux-pci@atrey.karlin.mff.cuni.cz, Greg Kroah-Hartman , "David S. Miller" , Benjamin Herrenschmidt , , Andrew Morton , Subject: Re: [PATCH 4/21] MSI: Simplify BUG() handling in msi_remove_pci_irq_vectors() part 2 References: <20070322105334.B5A46DDF59@ozlabs.org> Date: Tue, 27 Mar 2007 21:26:34 -0600 In-Reply-To: <20070322105334.B5A46DDF59@ozlabs.org> (Michael Ellerman's message of "Thu, 22 Mar 2007 21:51:31 +1100") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Michael Ellerman writes: > Although it might be nice to do a printk before BUG'ing, it's really not > necessary, and it complicates the code. > > The behaviour has changed slightly, in that before we set a flag if the irq > had an action, and continued freeing the other irqs. But as I see it that's > all irrelevant because we end up BUG'ing anyway. Acked-by: "Eric W. Biederman"