public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: "Lu, Yinghai" <yinghai.lu@amd.com>
Cc: "Linus Torvalds" <torvalds@osdl.org>,
	"Andrew Morton" <akpm@osdl.org>, "Andi Kleen" <ak@suse.de>,
	linux-kernel@vger.kernel.org,
	"Natalie Protasevich" <Natalie.Protasevich@UNISYS.com>
Subject: Re: [PATCH] x86_64 irq: Use irq_domain in ioapic_retrigger_irq
Date: Tue, 17 Oct 2006 12:25:47 -0600	[thread overview]
Message-ID: <m1hcy294us.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <5986589C150B2F49A46483AC44C7BCA412D6F8@ssvlexmb2.amd.com> (Yinghai Lu's message of "Tue, 17 Oct 2006 11:09:28 -0700")

"Lu, Yinghai" <yinghai.lu@amd.com> writes:

> Can you change "unsigned vector" to "int vector" like other function?

It doesn't matter it is an 8 bit unsigned value.
So I made the minimal change necessary to get the bugs fixed.

Coping with the inconsistencies of the usage can be a separate patch.
That way we won't get functional and style changes confused.

Eric

  reply	other threads:[~2006-10-17 18:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-17 18:09 [PATCH] x86_64 irq: Use irq_domain in ioapic_retrigger_irq Lu, Yinghai
2006-10-17 18:25 ` Eric W. Biederman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-10-17 18:02 Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1hcy294us.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=Natalie.Protasevich@UNISYS.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=yinghai.lu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox