Re: [patch] x64: Avoid irq_chip mask/unmask in fixup_irqs for interrupt-remapping

Eric W. Biederman
2009-06-05T01:47:39Z

Suresh Siddha <suresh.b.siddha@intel.com> writes:

> On Thu, 2009-06-04 at 18:18 -0700, Suresh Siddha wrote:
>> On Thu, 2009-06-04 at 16:13 -0700, Eric W. Biederman wrote:
>> > Suresh Siddha <suresh.b.siddha@intel.com> writes:
>> >
>> > > From: Suresh Siddha <suresh.b.siddha@intel.com>
>> > > Subject: x64: Avoid irq_chip mask/unmask in fixup_irqs for interrupt-remapping
>> > >
>> > > In the presence of interrupt-remapping, irqs will be migrated in the
>> > > process context and we don't do (and there is no need to) irq_chip mask/unmask
>> > > while migrating the interrupt.
>> > >
>> > > Similarly fix the fixup_irqs() that get called during cpu offline and avoid
>> > > calling irq_chip mask/unmask for irqs that are ok to be migrated in the
>> > > process context.
>> > >
>> > > While we didn't observe any race condition with the existing code,
>> > > this change takes complete advantage of interrupt-remapping in
>> > > the newer generation platforms and avoids any potential HW lockup's
>> > > (that often worry Eric :)
>> >
>> > You now apparently fail to migrate the irq threads in tandem with
>> > the rest of the irqs.
>>
>> Eric, Are you referring to Gary's issues? As far as I understand, they
>> don't happen in the presence of interrupt-remapping.
>>
>> Can you ack this patch, as this avoid touching IO-APIC and MSI entries
>> and does fixup_irqs() in a much more reliable fashion.
>
> in the presence of interrupt-remapping ofcourse :)

As far as this patch goes it looks like an improvement.

Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>

However after looking at Gary's issues I see some things that are still wrong
on this path.

1) We don't do the part of irq migration that moves irq threads.
We aren't using irq threads yet but still

If we could figure out how to call irq_set_affinity for the IRQ_MOVE_PCNTXT
code path that would make the maintenance a lot simpler.

2) We still diverge on 32bit vs 64bit for no reason.
I expect the fixed 64bit version should be moved into apic/io_apic.c

3) We still enable irqs for a short while after this to let things drain.
I am wondering if that is really necessary. It does very simply
allow the irq cleanup ipi to happen, and it unjams any irqs that happened
before we migrated them.

If we wanted to very strictly follow the rules I guess we could do something
like the cleanup_ipi by hand on the cpu that is going down and rebroadcast
all of the pending irqs to another cpu to process.

Eric