Re: [RFC][PATCH 1/2] PM: Split up sysdev_[suspend|resume] from device_power_[down|up]

Linus Torvalds
2009-02-22T21:08:36Z

On Sun, 22 Feb 2009, Adrian Bunk wrote:
> ...
> MODPOST 2586 modules
> ERROR: "sysdev_resume" [arch/x86/kernel/apm.ko] undefined!
> ERROR: "sysdev_suspend" [arch/x86/kernel/apm.ko] undefined!
> make[2]: *** [__modpost] Error 1

Ahh. device_power_[down|up] were EXPORT_SYMBOL_GPL, so now that we've
split them, so must sysdev_[suspend|resume] be.

Does this fix it?

Linus
---
drivers/base/sys.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/base/sys.c b/drivers/base/sys.c
index c98c31e..ef2055e 100644
--- a/drivers/base/sys.c
+++ b/drivers/base/sys.c
@@ -432,6 +432,7 @@ aux_driver:
}
return ret;
}
+EXPORT_SYMBOL_GPL(sysdev_suspend);

/**
@@ -463,6 +464,7 @@ int sysdev_resume(void)
}
return 0;
}
+EXPORT_SYMBOL_GPL(sysdev_resume);

int __init system_bus_init(void)