Re: [PATCH] Undeprecate the sysctl system call

Eric W. Biederman
2006-10-18T03:43:08Z

Cal Peake <cp@absolutedigital.net> writes:

> On Tue, 17 Oct 2006, Andrew Morton wrote:
>
>> yes, it appears that we screwed that up, but I haven't got around to thinking
> about
>> it yet.
>
> Well, here's a patch that hopefully solves the mess :)
>
> From: Cal Peake <cp@absolutedigital.net>
>
> Undeprecate the sysctl system call and default to always include it with
> the option for embedded folks to exclude it. Also, remove it's entry from
> the feature removal file.
>
> Signed-off-by: Cal Peake <cp@absolutedigital.net>

NAK on the grounds that it does not fix the related wording in sysctl.h

As for the rest of this I disagree with this direction as it is not
fixing the status quo, just attempting to maintain it.

The status quo is that there is one ridiculous user in glibc that
doesn't break when sys_sysctl is not compiled in.

The status quo is that we don't properly maintain sysctl.h and we arbitrarily
change the numbers.

The status quo is that sys_sysctl has been deprecated for longer than
feature-removal.txt

If we choose to maintain this and step up to maintaining the binary
ABI which no one uses then I am happy.

If we agree to remove the useless thing I am also happy.

It is wrong to maintain the status quo. Who is volunteering to step
up to the plate and maintain this thing?

I have just about enough time and energy to finish killing sys_sysctl.

Contrary to Alan's assertion all of those binary numbers in sysctl.h
are not trivial to maintain or we would not have broken the ABI
several times in the 2.6 series. Although I do agree it should be
simple (not trivial) to maintain if we decide it is important.

Eric