Re: [PATCH] x86_64: Make NR_IRQS configurable in Kconfig

[ebiederm@xmission.com (Eric W. Biederman)]

"Randy.Dunlap" <rdunlap@xenotime.net> writes:

>> diff --git a/arch/x86_64/Kconfig b/arch/x86_64/Kconfig
>> index 7598d99..d744e5b 100644
>> --- a/arch/x86_64/Kconfig
>> +++ b/arch/x86_64/Kconfig
>> @@ -384,6 +384,19 @@ config NR_CPUS
>>  	  This is purely to save memory - each supported CPU requires
>>  	  memory in the static kernel configuration.
>>  
>> +config NR_IRQS
>> +	int "Maximum number of IRQs (224-4096)"
>> +	range 256 4096
>> +	depends on SMP
>> +	default "4096"
>> +	help
>> +	  This allows you to specify the maximum number of IRQs which this
>> +	  kernel will support. Current maximum is 4096 IRQs as that
>> +	  is slightly larger than has observed in the field.
>> +
>> +	  This is purely to save memory - each supported IRQ requires
>> +	  memory in the static kernel configuration.
>
> If (a) "nor does hardware typically provide that many irq sources"
> and (b) "This is purely to save memory", why is the default
> 4096 instead of something smaller?

a) Because I would like to flush out bugs.
b) Because I want a default that works for everyone.
c) Because with MSI we have a potential for large irq counts on most systems.
d) Because anyone who disagrees with me can send a patch and fix
   the default.
e) Because with the default number of cpus we can very close to needing
   this many irqs in the worst case.
f) This is much better than previous to my patch and setting NR_CPUS=255
   and getting 8K IRQS.
g) Because I probably should have been more inventive than copying the
   NR_IRQS text, but when I did the wording sounded ok to me.

Eric