Re: [PATCH 2/2] Initial generic hypertransport interrupt support.

Dave Olson
2006-07-13T18:15:19Z

On Thu, 13 Jul 2006, Eric W. Biederman wrote:
| And I tested it on one of them. The problem is that there is no API in
| the kernel for properly handling hypertransport interrupts or even faking
| it well currently. There is no shame in breaking a bad unmaintainable
| hack, as I did. The responsible thing is to when you find one to
| fix up the code so that things work by design in a maintainable way,
| which I am attempting to do.

There's no problem providing a better replacement, just make sure
that the existing drivers can use it.

| All existing drivers that use HT interrupts are broken by design.

That's a statement designed to provoke arguments, and I'll just leave
it that we disagree.

| Sure. In that case can I please have a good description of what
| weird hacks your hardware designers have done.

There's really nothing special at all about the interrupt
setup, except in one very minor way. The value of the HT interrupt
destination address needs to be copied from HT config space, to
an internal chip register (which is, can, and should be, handled by
the driver init code).

| As I understand
| it I cannot write to the standard registers HT capability registers
| and have things work correctly.

There is nothing unusual or special about that part at all. The only
unusual item is that mentioned in the paragraph above.

| The functions I exported I intend to export. The complaint seems to
| be that you don't have anything that will work on earlier kernels.
| I have to agree you don't.

Huh? I didn't say anything that could possibly be read as applying
to earlier kernels, and to be crystal clear, that's not my concern
at all.

Maybe somebody else can articulate what I'm trying to say, but I don't
think I can say it in a clearer way.

Dave Olson
dave.olson@qlogic.com