From: Andi Kleen <ak@muc.de>
To: linux-os@analogic.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: remap_pfm_range() Linux-2.6.10
Date: Wed, 05 Jan 2005 16:17:46 +0100 [thread overview]
Message-ID: <m1k6qrdhwl.fsf@muc.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0501050951520.13645@chaos.analogic.com> (linux-os@chaos.analogic.com's message of "Wed, 5 Jan 2005 10:00:24 -0500 (EST)")
linux-os <linux-os@chaos.analogic.com> writes:
> remap_pfn_range(vma, vma->vm_start, base_addr >> PAGE_SHIFT, len, prot)
>
> Now, here's the $US0.02 question. Why wasn't PAGE_SHIFT put inside
> the new function? The base address cannot ever be used without
> PAGE_SHIFT. In previous versions, information hiding was properly
Because such a conversion would be very error prone. People would
likely add subtle bugs. Changing units is always dangerous.
-Andi
next prev parent reply other threads:[~2005-01-05 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-05 15:00 remap_pfm_range() Linux-2.6.10 linux-os
2005-01-05 15:17 ` Andi Kleen [this message]
2005-01-05 15:38 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1k6qrdhwl.fsf@muc.de \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox