public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Cong Wang <amwang@redhat.com>
Cc: Octavian Purdila <opurdila@ixiacom.com>,
	David Miller <davem@davemloft.net>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Linux Kernel Developers <linux-kernel@vger.kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [net-next PATCH v4 0/3] net: reserve ports for applications using fixed port
Date: Wed, 17 Feb 2010 08:10:21 -0800	[thread overview]
Message-ID: <m1ljer3ksy.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <4B7C11D4.1080309@redhat.com> (Cong Wang's message of "Wed\, 17 Feb 2010 23\:57\:08 +0800")

Cong Wang <amwang@redhat.com> writes:

> Octavian Purdila wrote:
>> On Tuesday 16 February 2010 22:08:13 you wrote:
>>>> Something like bellow?
>>>>
>>>> # set bits 8080 and 1666
>>>> $echo 8080 1666-1666 > /proc
>>>>
>>>> #reset bit 1666
>>>> $echo 8080 > /proc
>>>>
>>>> #reset whole bitmap
>>>> $echo > /proc
>>> Yes. So something like that.
>>>
>>> I think I would use commas instead of spaces as that is more traditional.
>
>
> Why this is better than the current version?
>
> For the single port case, currently we use:
>
> echo +8080 > /xxxx #set
> echo -8080 > /xxxx #clear
>
> Now we will use:
>
> echo 8080 > /xxxx #set
> echo 8080 > /xxxx #clear

No.

> I don't think the latter is better...
>
> For the multi-port case, yes, we should accept 'echo 8080,10000 >/xxxx'.

What I was envisioning was:

echo 8080 > /xxx # set the bitmap to 8080
echo 8080,10000 > /xxx # add 10000 to the bitmap
echo 8080 > /xxxx # remove 10000 from the bitmap.

That is when you set it you enter the entire set every time, treating
the entire set as a single value.

Eric

  reply	other threads:[~2010-02-17 16:10 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-15 22:00 [net-next PATCH v4 0/3] net: reserve ports for applications using fixed port Octavian Purdila
2010-02-15 22:00 ` [net-next PATCH v4 1/3] sysctl: refactor integer handling proc code Octavian Purdila
2010-02-16  8:41   ` Cong Wang
2010-02-16 10:48     ` Octavian Purdila
2010-02-16 13:08       ` Cong Wang
2010-02-16 14:00         ` Octavian Purdila
2010-02-17 16:31           ` Cong Wang
2010-02-17 21:09             ` Octavian Purdila
2010-02-18  3:58       ` Octavian Purdila
2010-02-16 11:41     ` Octavian Purdila
2010-02-16 13:09       ` Cong Wang
2010-02-16 13:44         ` Octavian Purdila
2010-02-17 16:21           ` Cong Wang
2010-02-17 16:33             ` Eric W. Biederman
2010-02-18  4:25               ` Octavian Purdila
2010-02-15 22:00 ` [net-next PATCH v4 2/3] sysctl: add proc_dobitmap Octavian Purdila
2010-02-16  9:12   ` Cong Wang
2010-02-15 22:00 ` [net-next PATCH v4 3/3] net: reserve ports for applications using fixed port numbers Octavian Purdila
2010-02-16  9:37   ` Cong Wang
2010-02-16 11:06     ` Octavian Purdila
2010-02-16 13:06       ` Cong Wang
2010-02-16 13:20         ` Eric Dumazet
2010-02-17 16:13           ` Cong Wang
2010-02-17 16:39             ` Eric Dumazet
2010-02-17 16:01               ` Octavian Purdila
2010-02-20  8:00               ` Cong Wang
2010-02-16 14:25         ` Octavian Purdila
2010-02-17 16:07           ` Cong Wang
2010-02-16 17:25 ` [net-next PATCH v4 0/3] net: reserve ports for applications using fixed port Eric W. Biederman
2010-02-16 18:04   ` Octavian Purdila
2010-02-16 18:49     ` Eric W. Biederman
2010-02-16 19:51       ` Octavian Purdila
2010-02-16 20:08         ` Eric W. Biederman
2010-02-16 21:22           ` Octavian Purdila
2010-02-17 15:57             ` Cong Wang
2010-02-17 16:10               ` Eric W. Biederman [this message]
2010-02-17 16:19                 ` Cong Wang
2010-02-17 16:26                   ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1ljer3ksy.fsf@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=opurdila@ixiacom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox