[PATCH] Free the memory allocated by memdup_user() in fs/sysfs/bin.c

[PATCH] Free the memory allocated by memdup_user() in fs/sysfs/bin.c

[Catalin Marinas]

Commit 1c8542c7bb replaced kmalloc() with memdup_user() in the write()
function but also dropped the kfree(temp). The memdup_user() function
allocates memory which is never freed.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Parag Warudkar <parag.warudkar@gmail.com>
---
 fs/sysfs/bin.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c
index 9345806..2524714 100644
--- a/fs/sysfs/bin.c
+++ b/fs/sysfs/bin.c
@@ -171,6 +171,7 @@ static ssize_t write(struct file *file, const char __user *userbuf,
 	if (count > 0)
 		*off = offs + count;
 
+	kfree(temp);
 	return count;
 }
 

Re: [PATCH] Free the memory allocated by memdup_user() in fs/sysfs/bin.c

[Eric W. Biederman]

Catalin Marinas <catalin.marinas@arm.com> writes:

> Commit 1c8542c7bb replaced kmalloc() with memdup_user() in the write()
> function but also dropped the kfree(temp). The memdup_user() function
> allocates memory which is never freed.

Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Parag Warudkar <parag.warudkar@gmail.com>
> ---
>  fs/sysfs/bin.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c
> index 9345806..2524714 100644
> --- a/fs/sysfs/bin.c
> +++ b/fs/sysfs/bin.c
> @@ -171,6 +171,7 @@ static ssize_t write(struct file *file, const char __user *userbuf,
>  	if (count > 0)
>  		*off = offs + count;
>  
> +	kfree(temp);
>  	return count;
>  }
>  
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/