Re: [PATCH 22/23] sysctl arm: Remove binary sysctl support

Andi Kleen
2009-11-09T09:38:03Z

ebiederm@xmission.com (Eric W. Biederman) writes:
>
> The glibc pthread code that uses sysctl has no problems if sys_sysctl
> is gone. It both falls back to reading /proc/sys and it just controls
> an optimization and the code works with either result. Been there,
> done that.

/proc/sys is much slower than sysctl though. So you made program startup
slower.

Also I agree with Arjan that breaking such a common ABI is not
really a good idea. But I think it's enough to only handle
common sysctls that are actually used, which are very few.

It would be better to simply keep the commonly used binary sysctls
as emulation around always (commonly = used by glibc and perhaps
added by user printk feedback) That's very cheap because it's just
a simple translation and can be done internally cheaper than going
through the VFS with a bazillion of locks.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.