Re: [git pull] VFS patches, the first series

[ebiederm@xmission.com (Eric W. Biederman)]

ebiederm@xmission.com (Eric W. Biederman) writes:

> Al Viro <viro@ZenIV.linux.org.uk> writes:
>
>> The first part of huge pile.  Mostly it's untangling nameidata handling,
>> digging towards the pieces that kill intents and cleaning pathname
>> resolution in general.  ->permission() sanitizing and sysctl procfs
>> treatment rewrite needed for it.  A bunch of descriptor handling fixes.
>> Plus part of assorted patched from the last cycle sent by other folks.
>> A _lot_ more is still pending; this is what I'd managed to pull into
>> a series by this point.  Please, pull from
>> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus
>
> Al a quick heads up.  In testing movement of network devices between
> namespaces  I hit the recently added WARN_ON in unregister_sysctl_table.

It seems to be some new oddness when destroying a network namespace.

If I don't have network devices to push out of the network namespace
when I clean it up nothing happens.  When I do I get this nice beautiful
backtrace.

I will dig into the sysctl code in a bit and see if I can understand
why this is happening.

------------[ cut here ]------------
WARNING: at /home/eric/projects/linux/linux-2.6-arastra-ns/kernel/sysctl.c:1929 unregister_sysctl_table+0xb5/0x
e5()
Modules linked in:
Pid: 22, comm: netns Tainted: G        W 2.6.27-rc3x86_64 #48

Call Trace:
 [<ffffffff802361da>] warn_on_slowpath+0x51/0x77
 [<ffffffff8023c631>] unregister_sysctl_table+0x34/0xe5
 [<ffffffff8023c6b2>] unregister_sysctl_table+0xb5/0xe5
 [<ffffffff80523f8c>] neigh_sysctl_unregister+0x1a/0x31
 [<ffffffff80559635>] inetdev_event+0x2b4/0x3d1
 [<ffffffff8024b850>] notifier_call_chain+0x29/0x56
 [<ffffffff8051fa2a>] dev_change_net_namespace+0x1bb/0x1da
 [<ffffffff8051fa9d>] default_device_exit+0x54/0xa2
 [<ffffffff8052105e>] netdev_run_todo+0x1fd/0x206
 [<ffffffff8051ce0b>] cleanup_net+0x0/0x95
 [<ffffffff8051ce6f>] cleanup_net+0x64/0x95
 [<ffffffff80244e58>] run_workqueue+0xf1/0x1ee
 [<ffffffff80244e02>] run_workqueue+0x9b/0x1ee
 [<ffffffff802459ee>] worker_thread+0xd8/0xe3
 [<ffffffff80248426>] autoremove_wake_function+0x0/0x2e
 [<ffffffff80245916>] worker_thread+0x0/0xe3
 [<ffffffff80248311>] kthread+0x47/0x76
 [<ffffffff805c7529>] trace_hardirqs_on_thunk+0x3a/0x3f
 [<ffffffff8020cdc9>] child_rip+0xa/0x11
 [<ffffffff8020c3ff>] restore_args+0x0/0x30
 [<ffffffff80230bcd>] finish_task_switch+0x0/0xc4
 [<ffffffff802482ca>] kthread+0x0/0x76
 [<ffffffff8020cdbf>] child_rip+0x0/0x11

---[ end trace f9cc56de378eb3ce ]---