From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754741AbYHTHEX (ORCPT ); Wed, 20 Aug 2008 03:04:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752225AbYHTHEE (ORCPT ); Wed, 20 Aug 2008 03:04:04 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:58238 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751854AbYHTHEC (ORCPT ); Wed, 20 Aug 2008 03:04:02 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: "Rafael J. Wysocki" Cc: "Jeff Garzik" , David Miller , "Yinghai Lu" , "Ingo Molnar" , "Andrew Morton" , linux-kernel@vger.kernel.org, netdev , "Jesse Barnes" , "Simon Arlott" References: <1218954333-12819-1-git-send-email-yhlu.kernel@gmail.com> <200808190008.54743.rjw@sisk.pl> <86802c440808181536j2c214cc3k47e73fd147b4fee1@mail.gmail.com> <200808192045.54779.rjw@sisk.pl> Date: Wed, 20 Aug 2008 00:01:33 -0700 In-Reply-To: <200808192045.54779.rjw@sisk.pl> (Rafael J. Wysocki's message of "Tue, 19 Aug 2008 20:45:53 +0200") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SA-Exim-Connect-IP: 24.130.11.59 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-DCC: XMission; sa03 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *****;"Rafael J. Wysocki" X-Spam-Relay-Country: X-Spam-Report: * 7.0 XM_URI_RBL URI's domain appears in surbl.xmission.com * [URIs: marc.info] * -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -0.2 BAYES_40 BODY: Bayesian spam probability is 20 to 40% * [score: 0.3372] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa03 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 XM_SPF_Neutral SPF-Neutral Subject: Re: [PATCH] forcedeth: Fix kexec regression X-SA-Exim-Version: 4.2 (built Thu, 03 Mar 2005 10:44:12 +0100) X-SA-Exim-Scanned: Yes (on mgr1.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Rafael J. Wysocki" writes: > From: Rafael J. Wysocki > > forcedeth: Fix kexec regression > > Fix regression tracked as > http://bugzilla.kernel.org/show_bug.cgi?id=11361 and > caused by commit f735a2a1a4f2a0f5cd823ce323e82675990469e2 > ("[netdrvr] forcedeth: setup wake-on-lan before shutting down") > that makes network adapters integrated into the NVidia > MCP55 chipsets fail to work in kexeced kernels. The problem appears > to be that if the adapter is put into D3_hot during ->shutdown(), > it cannot be brought back into D0 after kexec (ref. > http://marc.info/?l=linux-kernel&m=121900062814967&w=4). Therefore, > only put forcedeth into D3 during ->shutdown() if the system is to be > powered off. Any chance we can fix this by teaching the forcedeth driver to bring a card out of PCI_D3hot? The kexec on panic guys are going to need that and it is just generally more robust all of the way around than a special case in shutdown based on system_state. Eric