From: ebiederm@xmission.com (Eric W. Biederman)
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Removal of pci_find_* in 2.5
Date: 16 Jul 2002 04:56:53 -0600 [thread overview]
Message-ID: <m1ofd8ndoq.fsf@frodo.biederman.org> (raw)
In-Reply-To: <20020716002530.GA32431@kroah.com>
Greg KH <greg@kroah.com> writes:
> On Sun, Jul 14, 2002 at 02:07:01PM -0600, Eric W. Biederman wrote:
> >
> > The driver is a mtd map driver. It knows there is a rom chip behind
> > a pci->isa bridge. And it needs to find the pci->isa bridge to
> > properly set it up to access the rom chip (enable writes and the
> > like).
> >
> > It isn't a driver for the pci->isa bridge, (I'm not even certain we
> > have a good model for that). So it does not use pci_register_driver.
> >
> > If you can give me a good proposal for how to accomplish that kind of
> > functionality I would be happy to use the appropriate
> > xxx_register_driver.
>
> I don't think there is a good way for you to convert over to
> _register_driver(), that's the main reason I'm keeping the pci_find_*
> functions around, they are quite useful for lots of situations.
>
> It doesn't sound like you are worrying about your device working in a
> pci hotplug system, and you would probably be willing do any pci device
> conversion work to the new driver model yourself, right? :)
Assuming I can actually fit in better with the new driver model. As
far as hot-plug. It is an abuse but I regularly hot-swap my rom chips
in my development system.
I am probably looking at this from the wrong angle but my problem with
current code base seems to be that I can only have one driver per pci
device.
In any case I would like to have code that fits in nicely with the
new driver system. I can take about one change in kernel API. For
the most part the drivers are trivial, and having non-trivial
maintenance for trivial code is less than ideal.
Eric
next prev parent reply other threads:[~2002-07-16 11:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-13 0:36 Removal of pci_find_* in 2.5 Greg KH
2002-07-13 2:23 ` Alan Cox
2002-07-13 1:12 ` David S. Miller
2002-07-13 14:46 ` Alan Cox
2002-07-13 20:52 ` David S. Miller
2002-07-13 13:45 ` Benjamin Herrenschmidt
2002-07-15 5:25 ` David S. Miller
2002-07-16 0:26 ` Greg KH
2002-07-14 20:07 ` Eric W. Biederman
2002-07-16 0:25 ` Greg KH
2002-07-16 10:56 ` Eric W. Biederman [this message]
2002-07-16 17:33 ` Patrick Mochel
2002-07-17 12:41 ` Eric W. Biederman
-- strict thread matches above, loose matches on Subject: below --
2002-07-13 4:04 Matt_Domsch
2002-07-13 4:41 ` Jeff Garzik
2002-07-13 5:09 ` Greg KH
2002-07-13 14:35 ` Alan Cox
2002-07-13 15:37 ` Jeff Garzik
2002-07-13 17:06 ` Alan Cox
2002-07-13 19:28 ` Jeff Garzik
2002-07-13 19:33 ` Jeff Garzik
2002-07-13 13:13 Matt_Domsch
2002-07-16 19:23 Matt_Domsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1ofd8ndoq.fsf@frodo.biederman.org \
--to=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox