From: ebiederm@xmission.com (Eric W. Biederman)
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Pavel Machek <pavel@ucw.cz>, "Huang, Ying" <ying.huang@intel.com>,
nigel@nigel.suspend2.net,
Andrew Morton <akpm@linux-foundation.org>,
Jeremy Maitin-Shepard <jbms@cmu.edu>,
linux-kernel@vger.kernel.org,
linux-pm@lists.linux-foundation.org,
Kexec Mailing List <kexec@lists.infradead.org>
Subject: Re: [PATCH 1/4 -mm] kexec based hibernation -v7 : kexec jump
Date: Sat, 08 Dec 2007 18:06:02 -0700 [thread overview]
Message-ID: <m1prxgoex1.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <200712090119.57826.rjw@sisk.pl> (Rafael J. Wysocki's message of "Sun, 9 Dec 2007 01:19:56 +0100")
"Rafael J. Wysocki" <rjw@sisk.pl> writes:
>> I'm not kexec hacker... but maybe this is in good enough state to be
>> merged? It is useful on its own: kexec jump and back means we can dump
>> system then continue running, for example...
>
> As far as I'm concerned, patches [1/4] and [2/4] can go.
>
> The other two are not in that shape yet (especially the [3/4] patch).
Ok. Then I will see if I can review these in the next couple days
and give some feedback.
At a quick skim through the code it appears there is some more infrastructure
then we need and things can still be simplified.
Since this applies in particular to the user space interface I'm not comfortable
with these patches going in just yet.
The unused KEXEC_PRESERVE_ flags especially give me pause. Having something
like that, that isn't currently wired up sounds like a bad place to start.
Eric
next prev parent reply other threads:[~2007-12-09 1:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-07 15:53 [PATCH 1/4 -mm] kexec based hibernation -v7 : kexec jump Huang, Ying
2007-12-08 23:53 ` Pavel Machek
2007-12-09 0:19 ` Rafael J. Wysocki
2007-12-09 1:06 ` Eric W. Biederman [this message]
2007-12-10 19:55 ` Vivek Goyal
2007-12-11 8:51 ` Huang, Ying
2007-12-10 22:31 ` Vivek Goyal
2007-12-11 8:55 ` Huang, Ying
2007-12-11 2:25 ` Eric W. Biederman
2007-12-11 15:50 ` Huang, Ying
2007-12-11 9:27 ` Eric W. Biederman
2007-12-12 6:27 ` Huang, Ying
2007-12-18 8:34 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1prxgoex1.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=jbms@cmu.edu \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=nigel@nigel.suspend2.net \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox