From: Andi Kleen <ak@muc.de>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: torvalds@osdl.org, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] periodically scan redzone entries and slab control structures
Date: Tue, 04 Jan 2005 12:55:21 +0100 [thread overview]
Message-ID: <m1r7l1wgra.fsf@muc.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0501032223360.1865-100000@dbl.q-ag.de> (Manfred Spraul's message of "Mon, 3 Jan 2005 22:29:22 +0100 (CET)")
Manfred Spraul <manfred@colorfullife.com> writes:
> The redzone words are only checked during alloc and free - thus objects
> that are never/rarely freed are not checked at all.
>
> The attached patch adds a periodic scan over all objects and checks for
> wrong redzone data or corrupted bufctl lists.
>
> Most changes are under #ifdef DEBUG, the only exception is a trivial
> correction for the initial timeout calculation: divide the cachep address
> by L1_CACHE_BYTES before the mod - the low order bits are always 0.
Very nice patch. One request: Can you global and EXPORT_SYMBOL
the scanning function?
There is a kernel testing technique called "thrashing" that relies
on doing some custom stress from a kernel module and then checking
all state very often to catch corruption early. Calling the slab check m
ore often from such a test module would be useful.
Also I would make the slab test interval a kernel parameter to
force more regular checking during stress testing.
-Andi
next prev parent reply other threads:[~2005-01-04 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-03 21:29 [PATCH] periodically scan redzone entries and slab control structures Manfred Spraul
2005-01-04 11:55 ` Andi Kleen [this message]
2005-01-04 14:01 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1r7l1wgra.fsf@muc.de \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox