From: ebiederm@xmission.com (Eric W. Biederman)
To: David Woodhouse <dwmw2@infradead.org>
Cc: Matthew Gardiner <kiwiunix@ihug.co.nz>,
linux-kernel@vger.kernel.org, torvalds@transmeta.com,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] Re: MTD compiling error
Date: 20 Jul 2001 12:37:22 -0600 [thread overview]
Message-ID: <m1r8vb1m71.fsf@frodo.biederman.org> (raw)
In-Reply-To: <01072012460800.09910@kiwiunix.ihug.co.nz> <27335.995623038@redhat.com>
In-Reply-To: <27335.995623038@redhat.com>
David Woodhouse <dwmw2@infradead.org> writes:
> kiwiunix@ihug.co.nz said:
> > /usr/src/linux-2.4.6/include/linux/mtd/cfi.h:387: `do_softirq' undeclared
> (first use in this function)
Dave this isn't a sufficient fix. In particular amd_flash.c has problems,
if you only patch cfi.h. The problem is local_bh_enable by way of
do_unlock_bh. Or in particular the changes to asm-i386/softirq.h
The following should fix every case the changes to softirq.h broke. I would
love to include linux/interrupt.h but that isn't currently possible.
Eric
--- linux-2.4.6/include/asm-i386/softirq.h Thu Jul 19 15:33:26 2001
+++ linux-2.4.6.eb1.1/include/asm-i386/softirq.h Thu Jul 19 17:19:04 2001
@@ -4,6 +4,12 @@
#include <asm/atomic.h>
#include <asm/hardirq.h>
+/* FIXME getting the declaraion for do_softirq from interrupt.h is an
+ * include nightmare, this needs to be fixed instead of declaring
+ * do_softirq directly.
+ */
+extern asmlinkage void do_softirq(void);
+
#define __cpu_bh_enable(cpu) \
do { barrier(); local_bh_count(cpu)--; } while (0)
#define cpu_bh_disable(cpu) \
prev parent reply other threads:[~2001-07-20 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-20 0:46 MTD compiling error Matthew Gardiner
[not found] ` <3B5789F0.60605E80@resilience.com>
2001-07-20 3:59 ` Matthew Gardiner
2001-07-20 4:06 ` Tim Hockin
2001-07-20 9:57 ` [PATCH] " David Woodhouse
2001-07-20 18:37 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1r8vb1m71.fsf@frodo.biederman.org \
--to=ebiederm@xmission.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dwmw2@infradead.org \
--cc=kiwiunix@ihug.co.nz \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox