Re: [PATCH] [25/98] x86, AMD: Fix APIC timer erratum 400 affecting K8 Rev.A-E processors

Boris Ostrovsky
2011-07-27T12:39:21Z

On 07/26/11 20:35, Andi Kleen wrote:
> 2.6.35-longterm review patch. If anyone has any objections, please let me know.
>
> ------------------
> From: Boris Ostrovsky<ostr@amd64.org>
>
> commit e20a2d205c05cef6b5783df339a7d54adeb50962 upstream.
>
> Older AMD K8 processors (Revisions A-E) are affected by erratum
> 400 (APIC timer interrupts don't occur in C states greater than
> C1). This, for example, means that X86_FEATURE_ARAT flag should
> not be set for these parts.
>
> This addresses regression introduced by commit
> b87cf80af3ba4b4c008b4face3c68d604e1715c6 ("x86, AMD: Set ARAT
> feature on AMD processors") where the system may become
> unresponsive until external interrupt (such as keyboard input)
> occurs. This results, for example, in time not being reported
> correctly, lack of progress on the system and other lockups.
>
> Reported-by: Joerg-Volker Peetz<jvpeetz@web.de>
> Tested-by: Joerg-Volker Peetz<jvpeetz@web.de>
> Acked-by: Borislav Petkov<borislav.petkov@amd.com>
> Signed-off-by: Boris Ostrovsky<Boris.Ostrovsky@amd.com>
> Signed-off-by: Andi Kleen<ak@linux.intel.com>
> Link: http://lkml.kernel.org/r/1304113663-6586-1-git-send-email-ostr@amd64.org
> Signed-off-by: Ingo Molnar<mingo@elte.hu>
> Signed-off-by: Greg Kroah-Hartman<gregkh@suse.de>
>
> ---
> arch/x86/kernel/cpu/amd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.35.y/arch/x86/kernel/cpu/amd.c
> ===================================================================
> --- linux-2.6.35.y.orig/arch/x86/kernel/cpu/amd.c
> +++ linux-2.6.35.y/arch/x86/kernel/cpu/amd.c
> @@ -651,7 +651,7 @@ cpu_dev_register(amd_cpu_dev);
> */
>
> const int amd_erratum_400[] =
> - AMD_OSVW_ERRATUM(1, AMD_MODEL_RANGE(0xf, 0x41, 0x2, 0xff, 0xf),
> + AMD_OSVW_ERRATUM(1, AMD_MODEL_RANGE(0x0f, 0x4, 0x2, 0xff, 0xf),
> AMD_MODEL_RANGE(0x10, 0x2, 0x1, 0xff, 0xf));
>
>
>

Andi, this patch is unnecessary.

It (as well as 328935e6348c6a7cb34798a68c326f4b8372e68a and
14fb57dccb6e1defe9f89a66f548fcb24c374c1d) is superseded by
e9cdd343a5e42c43bcda01e609fa23089e026470 upstream

-boris