From: ebiederm@xmission.com (Eric W. Biederman)
To: Thomas Meyer <thomas@m3y3r.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Unset msi and msix flags on pci_device_disable
Date: Wed, 21 Mar 2007 23:23:33 -0600 [thread overview]
Message-ID: <m1tzwdam22.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <4601B012.6070802@m3y3r.de> (Thomas Meyer's message of "Wed, 21 Mar 2007 23:22:10 +0100")
Thomas Meyer <thomas@m3y3r.de> writes:
> The commit f5f2b13129a6541debf8851bae843cbbf48298b7 broke suspend/resume
> to disk two or more times in a row. This patches fixes the problem:
Please clue me in, on what the problem is, I see why my patch would
have changed things I don't see how it is breaking things. Clearing
the device bits has no effect on the hardware and it leaks our
msi handling data structures.
What is the user doing that this code broke?
I will be happy to work through a proper fix but this isn't it.
If this is actually helps something I am tempted to make the
added lines say WARN_ON.....
But I would really like to understand the nature of the problem
so that we can do something to fix it properly.
Eric
prev parent reply other threads:[~2007-03-22 5:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 22:22 [PATCH] Unset msi and msix flags on pci_device_disable Thomas Meyer
2007-03-22 5:23 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1tzwdam22.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox