From: ebiederm@xmission.com (Eric W. Biederman)
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Robin Holt <holt@sgi.com>, Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org
Subject: Re: max_user_watches overflows on 16TB system.
Date: Fri, 01 Oct 2010 20:04:06 -0700 [thread overview]
Message-ID: <m1vd5ll2hl.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1010011335400.2305@ubuntu> (Davide Libenzi's message of "Fri, 1 Oct 2010 13:37:08 -0700 (PDT)")
Davide Libenzi <davidel@xmailserver.org> writes:
> On Fri, 1 Oct 2010, Robin Holt wrote:
>
>>
>> Following a boot of a 16TB system, we noticed that the max_user_watches
>> sysctl was negative. Is there any downside to converting that to a
>> static long and handling the fallout from the change? I believe that
>> fallout includes changing the definition of epoll_watches over to an
>> atomic_long_t as well.
>>
>> Alternatively should we just limit max_user_watches to INT_MAX?
>
> 2B watches looks an acceptable limit to me, at least for now.
> Nobody complained about not having enough of them so far.
Which suggests that we need to force the boot time calculation to not
exceed 2B.
>From the sysctl interface perspective now that all of it is exported as
ascii strings I don't see a problem there.
Eric
next prev parent reply other threads:[~2010-10-02 3:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 20:01 max_user_watches overflows on 16TB system Robin Holt
2010-10-01 20:37 ` Davide Libenzi
2010-10-02 3:04 ` Eric W. Biederman [this message]
2010-10-02 14:04 ` Davide Libenzi
2010-10-04 19:44 ` [Patch] Convert max_user_watches to long Robin Holt
2010-10-06 2:21 ` Davide Libenzi
2010-10-09 7:50 ` Robin Holt
2010-10-10 19:05 ` Randy Dunlap
2010-10-11 4:49 ` Davide Libenzi
2010-10-14 17:15 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1vd5ll2hl.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=davidel@xmailserver.org \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox