public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pciehp:  Handle interrupts that happen during initialization.
Date: Mon, 23 Feb 2009 03:08:44 -0800	[thread overview]
Message-ID: <m1vdr15s1v.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <499BA141.2090403@jp.fujitsu.com> (Kenji Kaneshige's message of "Wed\, 18 Feb 2009 14\:48\:49 +0900")

Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> writes:

> Ok, I understood what is happening. Could you try the following patch?
> It is currently in Jesse's linux-next.
>
> http://marc.info/?l=linux-pci&m=123364118418484&w=2
>
> BTW, I don't think surprise removal is well tested.

That patch should guarantee that we don't loop forever, and if we are
going to loop that looks like a reasonable way to handle it.

When I start working on what is the most maintainable way to implement
merge my hotplug driver work I will come back and test this.

At the moment it appears that it will at least suffer from detecting a
presence change event with a device showing up.  Before pci structure
for the device is removed.  I seem to recall some dead locks on the
pciehp work queue hotunplugging a hotplug driver as well.

Eric

  reply	other threads:[~2009-02-23 11:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-29  3:31 [PATCH] pciehp: Handle interrupts that happen during initialization Eric W. Biederman
2009-01-29  7:34 ` Kenji Kaneshige
2009-02-13 19:29   ` Jesse Barnes
2009-02-14  4:06     ` Eric W. Biederman
2009-02-14 12:53       ` Eric W. Biederman
2009-02-14 14:56         ` Eric W. Biederman
2009-02-16  8:02           ` Kenji Kaneshige
2009-02-17 23:17             ` Eric W. Biederman
2009-02-18  5:48               ` Kenji Kaneshige
2009-02-23 11:08                 ` Eric W. Biederman [this message]
2009-02-24 17:05                   ` Jesse Barnes
2009-02-24 17:08                   ` Jesse Barnes
2009-02-16  8:00       ` Kenji Kaneshige
2009-02-18  0:40         ` Eric W. Biederman
2009-02-18  7:12           ` Kenji Kaneshige
2009-02-18  8:47             ` Eric W. Biederman
2009-02-20  6:18               ` Kenji Kaneshige
2009-02-23 11:17               ` Eric W. Biederman
2009-02-24 17:38 ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1vdr15s1v.fsf@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox