From: ebiederm@xmission.com (Eric W. Biederman)
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] exec: Cleanup exec from a non thread group leader.
Date: Mon, 30 Jan 2006 13:33:11 -0700 [thread overview]
Message-ID: <m1vew15ud4.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <43DE2730.795468DC@tv-sign.ru> (Oleg Nesterov's message of "Mon, 30 Jan 2006 17:48:16 +0300")
Oleg Nesterov <oleg@tv-sign.ru> writes:
> Oleg Nesterov wrote:
>>
>> Eric W. Biederman wrote:
>> >
>> > - list_add_tail(&thread->tasks, &init_task.tasks);
>>
>> The last deletion is wrong, I beleive.
>
> Just to clarify, it looks like we can kill this line because
> de_thread() also does list_add_tail(current, &init_task.tasks).
>
> But please note that it (and probably __ptrace_link() above)
> does list_del(current->task) first, and current->task may have
> very stale values after old leader called dup_task_struct().
> SET_LINKS() in copy_process() does nothing with ->tasks in a
> CLONE_THREAD case.
Good point in that instance we need to remove the list_del
as well.
As for the other stale data that bears looking at.
Eric
next prev parent reply other threads:[~2006-01-30 20:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-30 11:52 [PATCH] exec: Cleanup exec from a non thread group leader Oleg Nesterov
2006-01-30 14:48 ` Oleg Nesterov
2006-01-30 20:33 ` Eric W. Biederman [this message]
2006-01-31 10:07 ` Oleg Nesterov
2006-01-31 15:35 ` Eric W. Biederman
2006-01-30 20:27 ` Eric W. Biederman
-- strict thread matches above, loose matches on Subject: below --
2006-01-29 6:23 Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1vew15ud4.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox