public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: joe@perches.com, mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to
Date: Tue, 17 Nov 2009 01:55:53 -0800	[thread overview]
Message-ID: <m1ws1pfpau.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20091115105957.GA1935@x200> (Alexey Dobriyan's message of "Sun\, 15 Nov 2009 13\:59\:57 +0300")

Alexey Dobriyan <adobriyan@gmail.com> writes:

>> -		.proc_handler	= proc_dointvec
>> +		.proc_handler	= &proc_dointvec,
>
> NAK.
>
> commit 6d9f239a1edb31d6133230f478fd1dc2da338ec5
> Author: Alexey Dobriyan <adobriyan@gmail.com>
> Date:   Mon Nov 3 18:21:05 2008 -0800
>
>     net: '&' redux
>     
>     I want to compile out proc_* and sysctl_* handlers totally and
>     stub them to NULL depending on config options, however usage of &
>     will prevent this, since taking adress of NULL pointer will break
>     compilation.

I just experimented with this and found that at present a number of
the proc handlers wrap functions like proc_dointvec, so it does not work.

Did you have a plan for those?

Eric

  reply	other threads:[~2009-11-17  9:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-15 10:59 [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to Alexey Dobriyan
2009-11-17  9:55 ` Eric W. Biederman [this message]
2009-11-17 11:49   ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1ws1pfpau.fsf@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=adobriyan@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox