* Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to
@ 2009-11-15 10:59 Alexey Dobriyan
2009-11-17 9:55 ` Eric W. Biederman
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Dobriyan @ 2009-11-15 10:59 UTC (permalink / raw)
To: joe; +Cc: mingo, linux-kernel
> - .proc_handler = proc_dointvec
> + .proc_handler = &proc_dointvec,
NAK.
commit 6d9f239a1edb31d6133230f478fd1dc2da338ec5
Author: Alexey Dobriyan <adobriyan@gmail.com>
Date: Mon Nov 3 18:21:05 2008 -0800
net: '&' redux
I want to compile out proc_* and sysctl_* handlers totally and
stub them to NULL depending on config options, however usage of &
will prevent this, since taking adress of NULL pointer will break
compilation.
So, drop & in front of every ->proc_handler and every ->strategy
handler, it was never needed in fact.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to
2009-11-15 10:59 [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to Alexey Dobriyan
@ 2009-11-17 9:55 ` Eric W. Biederman
2009-11-17 11:49 ` Alexey Dobriyan
0 siblings, 1 reply; 3+ messages in thread
From: Eric W. Biederman @ 2009-11-17 9:55 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: joe, mingo, linux-kernel
Alexey Dobriyan <adobriyan@gmail.com> writes:
>> - .proc_handler = proc_dointvec
>> + .proc_handler = &proc_dointvec,
>
> NAK.
>
> commit 6d9f239a1edb31d6133230f478fd1dc2da338ec5
> Author: Alexey Dobriyan <adobriyan@gmail.com>
> Date: Mon Nov 3 18:21:05 2008 -0800
>
> net: '&' redux
>
> I want to compile out proc_* and sysctl_* handlers totally and
> stub them to NULL depending on config options, however usage of &
> will prevent this, since taking adress of NULL pointer will break
> compilation.
I just experimented with this and found that at present a number of
the proc handlers wrap functions like proc_dointvec, so it does not work.
Did you have a plan for those?
Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to
2009-11-17 9:55 ` Eric W. Biederman
@ 2009-11-17 11:49 ` Alexey Dobriyan
0 siblings, 0 replies; 3+ messages in thread
From: Alexey Dobriyan @ 2009-11-17 11:49 UTC (permalink / raw)
To: Eric W. Biederman; +Cc: joe, mingo, linux-kernel
On Tue, Nov 17, 2009 at 01:55:53AM -0800, Eric W. Biederman wrote:
> Alexey Dobriyan <adobriyan@gmail.com> writes:
> > net: '&' redux
> >
> > I want to compile out proc_* and sysctl_* handlers totally and
> > stub them to NULL depending on config options, however usage of &
> > will prevent this, since taking adress of NULL pointer will break
> > compilation.
>
> I just experimented with this and found that at present a number of
> the proc handlers wrap functions like proc_dointvec, so it does not work.
>
> Did you have a plan for those?
Of course, net/ was just first big step.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-17 11:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-15 10:59 [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to Alexey Dobriyan
2009-11-17 9:55 ` Eric W. Biederman
2009-11-17 11:49 ` Alexey Dobriyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox