From: ebiederm@xmission.com (Eric W. Biederman)
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Dominic Duval <dduval@redhat.com>,
Frank Hirtz <fhirtz@redhat.com>, "Fuller\,
Johnray" <Johnray.Fuller@gs.com>,
"James M. Leddy" <jleddy@redhat.com>,
Larry Woodman <lwoodman@redhat.com>,
Paul Batkowski <pbatkowski@redhat.com>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] proc_flush_task: flush /proc/tid/task/pid when a sub-thread exits
Date: Thu, 09 Jul 2009 13:32:58 -0700 [thread overview]
Message-ID: <m1ws6hr405.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20090709173610.GA29069@redhat.com> (Oleg Nesterov's message of "Thu\, 9 Jul 2009 19\:36\:10 +0200")
Oleg Nesterov <oleg@redhat.com> writes:
> Alexey, Eric, could you please review and ack/nack ?
>
> I just can't understand what was the reason for "if (thread_group_leader())"
> check in proc_flush_task() pathes.
Give me a day or two.
There are definitely bugs there. My cleanup patch for that has gotten
lost several times.
All of this is an optimization so it isn't critical we get this right.
Just a good idea.
Eric
prev parent reply other threads:[~2009-07-09 20:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 17:36 [PATCH 0/1] proc_flush_task: flush /proc/tid/task/pid when a sub-thread exits Oleg Nesterov
2009-07-09 20:32 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1ws6hr405.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=Johnray.Fuller@gs.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dduval@redhat.com \
--cc=fhirtz@redhat.com \
--cc=jleddy@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lwoodman@redhat.com \
--cc=oleg@redhat.com \
--cc=pbatkowski@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox