* [PATCH 0/1] proc_flush_task: flush /proc/tid/task/pid when a sub-thread exits
@ 2009-07-09 17:36 Oleg Nesterov
2009-07-09 20:32 ` Eric W. Biederman
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2009-07-09 17:36 UTC (permalink / raw)
To: Andrew Morton, Alexey Dobriyan, Eric W. Biederman
Cc: Dominic Duval, Frank Hirtz, Fuller, Johnray, James M. Leddy,
Larry Woodman, Paul Batkowski, Roland McGrath, linux-kernel
Alexey, Eric, could you please review and ack/nack ?
I just can't understand what was the reason for "if (thread_group_leader())"
check in proc_flush_task() pathes.
Oleg.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0/1] proc_flush_task: flush /proc/tid/task/pid when a sub-thread exits
2009-07-09 17:36 [PATCH 0/1] proc_flush_task: flush /proc/tid/task/pid when a sub-thread exits Oleg Nesterov
@ 2009-07-09 20:32 ` Eric W. Biederman
0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2009-07-09 20:32 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Alexey Dobriyan, Dominic Duval, Frank Hirtz,
Fuller, Johnray, James M. Leddy, Larry Woodman, Paul Batkowski,
Roland McGrath, linux-kernel
Oleg Nesterov <oleg@redhat.com> writes:
> Alexey, Eric, could you please review and ack/nack ?
>
> I just can't understand what was the reason for "if (thread_group_leader())"
> check in proc_flush_task() pathes.
Give me a day or two.
There are definitely bugs there. My cleanup patch for that has gotten
lost several times.
All of this is an optimization so it isn't critical we get this right.
Just a good idea.
Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-09 20:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-09 17:36 [PATCH 0/1] proc_flush_task: flush /proc/tid/task/pid when a sub-thread exits Oleg Nesterov
2009-07-09 20:32 ` Eric W. Biederman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox