From: ebiederm@xmission.com (Eric W. Biederman)
To: "Pan\, Jacob jun" <jacob.jun.pan@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Jeremy Fitzhardinge <jeremy@goop.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@linux.intel.com>
Subject: Re: [PATCH 8/9] x86/apic: match destination id with destination mode
Date: Fri, 26 Jun 2009 14:47:01 -0700 [thread overview]
Message-ID: <m1ws6yhdm2.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <43F901BD926A4E43B106BF17856F0755641A46AA@orsmsx508.amr.corp.intel.com> (Jacob jun Pan's message of "Fri\, 26 Jun 2009 13\:59\:02 -0700")
"Pan, Jacob jun" <jacob.jun.pan@intel.com> writes:
> [[JPAN]] For Moorestown production silicon, we will use apic_default which uses
> logical dest mode. This patch is not required.
> But, I think it is wrong to assign destination ID without looking at the mode
> bit. If we have a new apic_xxxx with phy dest mode, we would have logical APIC
> ID assigned to physical mode.
Both phys dest and logical dest use the same bits in the apic.
The code that assigns the destination knows which mode we are operating in.
Even not supporting logical mode is likely ok. The key thing is doing the
work in the auto detect logic and not doing something weird in the assignments.
Eric
next prev parent reply other threads:[~2009-06-26 21:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 0:15 [PATCH 8/9] x86/apic: match destination id with destination mode Pan, Jacob jun
2009-06-26 7:17 ` Ingo Molnar
2009-06-26 19:54 ` Eric W. Biederman
2009-06-26 20:59 ` Pan, Jacob jun
2009-06-26 21:47 ` Eric W. Biederman [this message]
2009-06-27 17:01 ` Ingo Molnar
2009-06-26 19:45 ` Eric W. Biederman
2009-06-26 21:21 ` Yinghai Lu
2009-06-26 21:41 ` Pan, Jacob jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1ws6yhdm2.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=hpa@linux.intel.com \
--cc=jacob.jun.pan@intel.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox