From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] buffer: Kill old incorrect? comment.
Date: Thu, 31 May 2007 10:43:06 -0600 [thread overview]
Message-ID: <m1wsyp2bc5.fsf_-_@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070531085556.11649c70.akpm@linux-foundation.org> (Andrew Morton's message of "Thu, 31 May 2007 08:55:56 -0700")
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
fs/buffer.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/fs/buffer.c b/fs/buffer.c
index c6b58e8..ad9270b 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1029,11 +1029,6 @@ failed:
/*
* Create buffers for the specified block device block's page. If
* that page was dirty, the buffers are set dirty also.
- *
- * Except that's a bug. Attaching dirty buffers to a dirty
- * blockdev's page can result in filesystem corruption, because
- * some of those buffers may be aliases of filesystem data.
- * grow_dev_page() will go BUG() if this happens.
*/
static int
grow_buffers(struct block_device *bdev, sector_t block, int size)
--
1.5.1.1.181.g2de0
next prev parent reply other threads:[~2007-05-31 16:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 2:31 [PATCH 1/3] Preserve the dirty bit in init_page_buffers Eric W. Biederman
2007-05-22 2:36 ` [PATCH 2/3] rd: Mark ramdisk buffer heads dirty in ramdisk_set_page_dirty Eric W. Biederman
2007-05-22 2:40 ` [PATCH 3/3] rd: Simplify by using the same helper functions in libfs Eric W. Biederman
2007-05-28 4:09 ` [PATCH 1/3] Preserve the dirty bit in init_page_buffers Nick Piggin
2007-05-28 4:30 ` Eric W. Biederman
2007-05-28 4:54 ` Nick Piggin
2007-05-28 4:59 ` Nick Piggin
2007-05-28 14:05 ` Eric W. Biederman
2007-05-29 5:14 ` Nick Piggin
2007-05-29 5:28 ` Eric W. Biederman
2007-05-31 11:56 ` Eric W. Biederman
2007-05-31 15:55 ` Andrew Morton
2007-05-31 16:40 ` [PATCH] rd: Remove ramdisk_set_page_dirty Eric W. Biederman
2007-05-31 16:43 ` Eric W. Biederman [this message]
2007-05-28 13:52 ` [PATCH 1/3] Preserve the dirty bit in init_page_buffers Eric W. Biederman
2007-05-28 6:37 ` Nick Piggin
2007-05-28 13:58 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1wsyp2bc5.fsf_-_@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox