From: Andi Kleen <ak@muc.de>
To: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Cc: rohit.seth@intel.com, asit.k.mallick@intel.com,
linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [Discuss][i386] Platform SMIs and their interferance with tsc based delay calibration
Date: Sat, 29 Jan 2005 07:24:15 +0100 [thread overview]
Message-ID: <m1wttwlpm8.fsf@muc.de> (raw)
In-Reply-To: <20050128185101.A19117@unix-os.sc.intel.com> (Venkatesh Pallipadi's message of "Fri, 28 Jan 2005 18:51:01 -0800")
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> writes:
> +
> + /*
> + * If the upper limit and lower limit of the tsc_rate is more than
> + * 12.5% apart.
> + */
> + if (pre_start == 0 || pre_end == 0 ||
> + (tsc_rate_max - tsc_rate_min) > (tsc_rate_max >> 3)) {
> + printk(KERN_WARNING "TSC calibration may not be precise. "
> + "Too many SMIs? "
> + "Consider running with \"lpj=\" boot option\n");
> + return 0;
> + }
I think it would be better to rerun it a few times automatically
before giving up. This way it would hopefully work transparently but slower
for most users. The message is too obscure too to be usable and needs
more explanation.
And also in case the platforms in questions support EM64T
x86-64 would need to be changed too :)
-Andi
next prev parent reply other threads:[~2005-01-29 6:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-29 2:51 [Discuss][i386] Platform SMIs and their interferance with tsc based delay calibration Venkatesh Pallipadi
2005-01-29 5:17 ` Andrew Morton
2005-01-29 6:24 ` Andi Kleen [this message]
2005-01-29 17:44 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2005-01-29 14:36 Pallipadi, Venkatesh
2005-01-29 14:37 Pallipadi, Venkatesh
[not found] <3rR0g-3aR-11@gated-at.bofh.it>
2005-01-31 17:25 ` Martin Wilck
[not found] ` <3s4Tx-1gi-9@gated-at.bofh.it>
2005-01-31 17:29 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1wttwlpm8.fsf@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=asit.k.mallick@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rohit.seth@intel.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox