From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
airlied@linux.ie, carlo@caione.org,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, victor.wan@amlogic.com,
jerry.cao@amlogic.com, Xing.Xu@amlogic.com,
devicetree@vger.kernel.org, daniel@ffwll.ch
Subject: Re: [PATCH v2 3/4] dt-bindings: display: add Amlogic Meson DRM Bindings
Date: Wed, 30 Nov 2016 08:21:18 -0800 [thread overview]
Message-ID: <m21sxtkkg1.fsf@baylibre.com> (raw)
In-Reply-To: <2e1b16c6-eec5-8cf3-5795-d6de02f36570@baylibre.com> (Neil Armstrong's message of "Wed, 30 Nov 2016 17:00:59 +0100")
Neil Armstrong <narmstrong@baylibre.com> writes:
> Hi Laurent,
> On 11/30/2016 04:58 PM, Laurent Pinchart wrote:
>> Hi Neil,
>>
>> On Wednesday 30 Nov 2016 16:43:44 Neil Armstrong wrote:
>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>> ---
>>> .../bindings/display/meson/meson-drm.txt | 101 ++++++++++++++++++
>>
>> I forgot to mention that the file should not be named meson-drm.txt as DRM is
>> a Linux-specific concept. You can name it meson.txt, but a better option would
>> be amlogic,meson.txt. By the way does it really need a subdirectory ?
>
> I took example of the sun4i layout the naming, and no it does not need a subdirector..
>
> I will move it to amlogic,meson.txt, seems far better.
>
To me, amlogic,meson is redundant. Probably should be amlogic,vpu.txt?
Kevin
next prev parent reply other threads:[~2016-11-30 16:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 15:43 [PATCH v2 0/4] drm: Add support for the Amlogic Video Processing Unit Neil Armstrong
2016-11-30 15:43 ` [PATCH v2 1/4] drm: Add support for Amlogic Meson Graphic Controller Neil Armstrong
2016-11-30 16:03 ` Laurent Pinchart
2016-11-30 16:05 ` Neil Armstrong
2016-11-30 15:43 ` [PATCH v2 2/4] ARM64: dts: meson-gx: Add Graphic Controller nodes Neil Armstrong
2016-11-30 16:02 ` Laurent Pinchart
2016-11-30 16:07 ` Neil Armstrong
2016-11-30 15:43 ` [PATCH v2 3/4] dt-bindings: display: add Amlogic Meson DRM Bindings Neil Armstrong
2016-11-30 15:56 ` Laurent Pinchart
2016-11-30 16:04 ` Neil Armstrong
2016-11-30 15:58 ` Laurent Pinchart
2016-11-30 16:00 ` Neil Armstrong
2016-11-30 16:21 ` Kevin Hilman [this message]
2016-11-30 16:22 ` Neil Armstrong
2016-11-30 15:43 ` [PATCH v2 4/4] MAINTAINERS: add entry for Amlogic DRM drivers Neil Armstrong
2016-11-30 15:59 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21sxtkkg1.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=Xing.Xu@amlogic.com \
--cc=airlied@linux.ie \
--cc=carlo@caione.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jerry.cao@amlogic.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=victor.wan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox